From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27741 invoked by alias); 14 May 2013 13:35:25 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 27674 invoked by uid 89); 14 May 2013 13:35:25 -0000 X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,FRT_OFFER2,KHOP_THREADED,SPF_PASS autolearn=no version=3.3.1 X-Spam-User: qpsmtpd, 2 recipients Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 14 May 2013 13:35:22 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 296E0A50E4; Tue, 14 May 2013 15:35:20 +0200 (CEST) Message-ID: <51923D97.9010703@suse.com> Date: Tue, 14 May 2013 13:35:00 -0000 From: Andreas Jaeger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Siddhesh Poyarekar Cc: libc-alpha@sourceware.org, libc-ports@sourceware.org Subject: Re: [PATCH][BZ #15465] Avoid crashing with LD_DEBUG=symbols when program name is unavailable References: <20130514103124.GN25336@spoyarek.pnq.redhat.com> In-Reply-To: <20130514103124.GN25336@spoyarek.pnq.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-05/txt/msg00057.txt.bz2 On 05/14/2013 12:31 PM, Siddhesh Poyarekar wrote: > Hi, > > The program name may be unavailable if the user application tampers > with argc and argv[]. Some parts of the dynamic linker check this > while others don't, so this patch consolidates the check and fallback > into a single macro and updates all users. I have also added a simple > test to verify the fix and have also verified that this does not > result in any regressions in the testsuite. > > I have made mechanical changes to architectures other than x86 (even > in ports), that I haven't tested. Could the maintainers test and give > feedback? Wow, the checking was really inconsistent throughout the code. I reviewed the changes and they look fine to me, Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126