From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-ports-return-4138-listarch-libc-ports=sources.redhat.com@sourceware.org>
Received: (qmail 17443 invoked by alias); 14 May 2013 15:47:46 -0000
Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-ports.sourceware.org>
List-Subscribe: <mailto:libc-ports-subscribe@sourceware.org>
List-Post: <mailto:libc-ports@sourceware.org>
List-Help: <mailto:libc-ports-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: libc-ports-owner@sourceware.org
Received: (qmail 17421 invoked by uid 89); 14 May 2013 15:47:45 -0000
X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS,TW_CP,TW_HW autolearn=ham version=3.3.1
Received: from mail-gh0-f178.google.com (HELO mail-gh0-f178.google.com) (209.85.160.178)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 14 May 2013 15:47:44 +0000
Received: by mail-gh0-f178.google.com with SMTP id g15so122631ghb.9        for <libc-ports@sourceware.org>; Tue, 14 May 2013 08:47:43 -0700 (PDT)
X-Received: by 10.236.50.132 with SMTP id z4mr18472911yhb.67.1368546462936;        Tue, 14 May 2013 08:47:42 -0700 (PDT)
Received: from anchor.twiddle.net (50-194-63-110-static.hfc.comcastbusiness.net. [50.194.63.110])        by mx.google.com with ESMTPSA id f71sm27237915yha.8.2013.05.14.08.47.41        for <multiple recipients>        (version=TLSv1 cipher=RC4-SHA bits=128/128);        Tue, 14 May 2013 08:47:42 -0700 (PDT)
Message-ID: <51925C9B.2030307@twiddle.net>
Date: Tue, 14 May 2013 15:47:00 -0000
From: Richard Henderson <rth@twiddle.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5
MIME-Version: 1.0
To: Roland McGrath <roland@hack.frob.com>
CC: libc-ports@sourceware.org
Subject: Re: [PATCH roland/arm-memcpy] ARM: Make multiarch memcpy always use   NEON when compiler does
References: <20130513224722.9F17C2C05E@topped-with-meat.com>
In-Reply-To: <20130513224722.9F17C2C05E@topped-with-meat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-SW-Source: 2013-05/txt/msg00058.txt.bz2

On 05/13/2013 03:47 PM, Roland McGrath wrote:
>    IFUNC_IMPL (i, name, memcpy,
>  	      IFUNC_IMPL_ADD (array, i, memcpy, hwcap & HWCAP_ARM_NEON,
> -			      __memcpy_neon)
> +#ifdef __ARM_NEON__
> +                              memcpy
> +#else
> +			      __memcpy_neon
> +#endif
> +                              )
> +#ifndef __ARM_NEON__
>  	      IFUNC_IMPL_ADD (array, i, memcpy, hwcap & HWCAP_ARM_VFP,
>  			      __memcpy_vfp)
> +#endif
>  	      IFUNC_IMPL_ADD (array, i, memcpy, 1, __memcpy_arm));

I think you're better off leaving the __memcpy_neon symbol in all cases.
Having memcpy be an alias to __memcpy_neon would make the rest of the patch
simpler.


r~