From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20690 invoked by alias); 14 May 2013 19:38:58 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 20666 invoked by uid 89); 14 May 2013 19:38:58 -0000 X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,FRT_OFFER2,KHOP_THREADED,SPF_PASS,TW_HW autolearn=no version=3.3.1 X-Spam-User: qpsmtpd, 2 recipients Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 14 May 2013 19:38:57 +0000 Received: from relay1.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id C804BA4EB7; Tue, 14 May 2013 21:38:54 +0200 (CEST) Message-ID: <519292C9.2080703@suse.com> Date: Tue, 14 May 2013 19:38:00 -0000 From: Andreas Jaeger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Edjunior Barbosa Machado Cc: libc-alpha@sourceware.org, libc-ports@sourceware.org, naveen.n.rao@linux.vnet.ibm.com Subject: Re: [PATCH] Update bits/siginfo.h with Linux hwpoison SIGBUS changes References: <1367901958-331-1-git-send-email-emachado@linux.vnet.ibm.com> In-Reply-To: <1367901958-331-1-git-send-email-emachado@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-05/txt/msg00061.txt.bz2 On 05/07/2013 06:45 AM, Edjunior Barbosa Machado wrote: > This patch adds new SIGBUS error codes for hardware poison signals, syncing > with the current kernel headers (v3.9). It also adds si_trapno field for alpha. > > Ok? > [...] > --- a/sysdeps/unix/sysv/linux/x86/bits/siginfo.h > +++ b/sysdeps/unix/sysv/linux/x86/bits/siginfo.h > @@ -107,6 +107,7 @@ typedef struct > struct > { > void *si_addr; /* Faulting insn/memory ref. */ > + short si_addr_lsb; /* Valid LSB of the reported address */ We normally end comments with a "." and two spaces, see above. Similar below and throughout the patch set. The code changes itself are fine. > } _sigfault; > > /* SIGPOLL. */ > @@ -139,6 +140,7 @@ typedef struct > # define si_int _sifields._rt.si_sigval.sival_int > # define si_ptr _sifields._rt.si_sigval.sival_ptr > # define si_addr _sifields._sigfault.si_addr > +# define si_addr_lsb _sifields._sigfault.si_addr_lsb > # define si_band _sifields._sigpoll.si_band > # define si_fd _sifields._sigpoll.si_fd > # define si_call_addr _sifields._sigsys._call_addr > @@ -229,8 +231,12 @@ enum > # define BUS_ADRALN BUS_ADRALN > BUS_ADRERR, /* Non-existant physical address. */ > # define BUS_ADRERR BUS_ADRERR > - BUS_OBJERR /* Object specific hardware error. */ > + BUS_OBJERR, /* Object specific hardware error. */ > # define BUS_OBJERR BUS_OBJERR > + BUS_MCEERR_AR, /* Hardware memory error: action required */ > +# define BUS_MCEERR_AR BUS_MCEERR_AR > + BUS_MCEERR_AO /* Hardware memory error: action optional */ > +# define BUS_MCEERR_AO BUS_MCEERR_AO > }; The last two added comments have the same problem. > > /* `si_code' values for SIGTRAP signal. */ > Could you update all the comments and resend, please? Thanks, Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126