public inbox for
 help / color / mirror / Atom feed
From: "Carlos O'Donell" <>
To: "Joseph S. Myers" <>
Cc: "" <>
Subject: Re: [COMMITTED] hppa: Update libm-test-ulps.
Date: Wed, 15 May 2013 21:12:00 -0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 05/15/2013 04:59 PM, Joseph S. Myers wrote:
> On Wed, 15 May 2013, Joseph S. Myers wrote:
>> It's not *new* here, but ulps for ceil, floor, rint, round, trunc indicate 
>> you've got bugs in those functions for long double; they shouldn't have 
>> any ulps at all.  And the ulps for llrint, llround also shouldn't be 
>> there, and include negative values, which should never happen even when 
>> the functions are buggy.
> In fact, why are these tests being run for long double at all - why are 
> there any long double ulps (presuming you truncated the file and 
> regenerated from scratch, as you should at least once per release cycle)?  

I've never regenerated from scratch. We have not recommended that in
Regeneration or the release process. I always regenerate incrementally
from the existing file. Though I see your point that we should probably
make this mandatory.

> You have long-double-fcts = no in your makefile.  Contradicting that, you 
> have #undef __NO_LONG_DOUBLE_MATH in ports/sysdeps/hppa/fpu/bits/mathdef.h 
> - if you really have long double same as double, that should be defined to 
> 1, not undefined.  I'm not sure the combination of long-double-fcts = no 
> with #undef __NO_LONG_DOUBLE_MATH is expected to do anything sensible.

Then that's a bug. We want to have long double the same as double.

> (However, I'd consider it inadvisable to fix the __NO_LONG_DOUBLE_MATH 
> definition before you've set up ABI test baselines for hppa and verified 
> them against old binaries of old releases - that sort of change has 
> significant risk of causing unintended changes to symbols in past ABI 
> versions.)



  reply	other threads:[~2013-05-15 21:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-15 16:29 Carlos O'Donell
2013-05-15 20:22 ` Joseph S. Myers
2013-05-15 21:00   ` Joseph S. Myers
2013-05-15 21:12     ` Carlos O'Donell [this message]
2013-05-15 21:16       ` Joseph S. Myers
2013-05-15 21:08   ` [COMMITTED] hppa: Cleanup libm-test-ulps Carlos O'Donell
2013-07-24  3:34 [COMMITTED] hppa: Update libm-test-ulps Carlos O'Donell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).