From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17545 invoked by alias); 23 May 2013 22:17:45 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 17535 invoked by uid 89); 23 May 2013 22:17:44 -0000 X-Spam-SWARE-Status: No, score=-7.9 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 23 May 2013 22:17:44 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4NMHguJ016698 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 23 May 2013 18:17:43 -0400 Received: from [10.3.113.131] (ovpn-113-131.phx2.redhat.com [10.3.113.131]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4NMHgpG004109; Thu, 23 May 2013 18:17:42 -0400 Message-ID: <519E9585.1090904@redhat.com> Date: Thu, 23 May 2013 22:17:00 -0000 From: "Carlos O'Donell" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Chris Metcalf CC: libc-ports@sourceware.org Subject: Re: [PATCH] tile: improve detection for missing -mcmodel=large support References: <201305231925.r4NJPPJG013785@farm-0002.internal.tilera.com> In-Reply-To: <201305231925.r4NJPPJG013785@farm-0002.internal.tilera.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00101.txt.bz2 On 05/23/2013 03:20 PM, Chris Metcalf wrote: > The existing test avoided passing -mcmodel=large if the compiler didn't > support it. However, we need to test not just the compiler support, but > also the toolchain (as and ld) support, so make the test more complete. > In addition, we have to avoid using the hwN_plt() assembly operators if > that support is missing, so guard the uses with #ifdef NO_PLT_PCREL. > > This allows us to properly build glibc with the current community > binutils, which doesn't yet have the PC-relative PLT operator support. > The -mcmodel=large support is in gcc 4.8, but the toolchain support > won't be present in the community until binutils 2.24. > --- > This change should also be applied on the 2.17 release branch for > when we release a 2.17.1. No, just backport it immediately after checkin to master. The 2.17 branch *is* 2.17.1 in development and when we get enough changes in that branch we cut it and make a 2.17.1 release. You need release manager ACK though, which is David Miller. We normally handle backports via bugzilla bugs with keyword glibc_2.17, but it can be less formal if you just CC David and ask for ACK. > 2013-05-23 Chris Metcalf > > * sysdeps/tile/tilegx/Makefile ($(cflags-mcmodel-large)): > Test for assembler and linker support for "-mcmodel=large -fpic" > in addition to compiler support; provide -DNO_PLT_PCREL if not. > * sysdeps/tile/start.S [NO_PLT_PCREL]: Guard for no PC-relative > PLT operators in assembly. > * sysdeps/tile/crti.S [NO_PLT_PCREL]: Likewise. I didn't look at the rest of the patch but I assume it works for you. Cheers, Carlos.