From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13384 invoked by alias); 24 May 2013 02:05:52 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 13329 invoked by uid 89); 24 May 2013 02:05:44 -0000 X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.1 Received: from usmamail.tilera.com (HELO USMAMAIL.TILERA.COM) (12.216.194.151) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 24 May 2013 02:05:43 +0000 Received: from [192.168.1.103] (98.217.155.22) by USMAExch2.tad.internal.tilera.com (10.3.0.33) with Microsoft SMTP Server id 14.0.722.0; Thu, 23 May 2013 22:05:41 -0400 Message-ID: <519ECAF3.1040700@tilera.com> Date: Fri, 24 May 2013 02:05:00 -0000 From: Chris Metcalf User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Carlos O'Donell CC: , "David S. Miller" Subject: Re: [PATCH] tile: improve detection for missing -mcmodel=large support References: <201305231925.r4NJPPJG013785@farm-0002.internal.tilera.com> <519E9585.1090904@redhat.com> In-Reply-To: <519E9585.1090904@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00102.txt.bz2 (Adding David explicitly to Cc.) On 5/23/2013 6:17 PM, Carlos O'Donell wrote: > On 05/23/2013 03:20 PM, Chris Metcalf wrote: >> The existing test avoided passing -mcmodel=large if the compiler didn't >> support it. However, we need to test not just the compiler support, but >> also the toolchain (as and ld) support, so make the test more complete. >> In addition, we have to avoid using the hwN_plt() assembly operators if >> that support is missing, so guard the uses with #ifdef NO_PLT_PCREL. >> >> This allows us to properly build glibc with the current community >> binutils, which doesn't yet have the PC-relative PLT operator support. >> The -mcmodel=large support is in gcc 4.8, but the toolchain support >> won't be present in the community until binutils 2.24. >> --- >> This change should also be applied on the 2.17 release branch for >> when we release a 2.17.1. > No, just backport it immediately after checkin to master. The 2.17 > branch *is* 2.17.1 in development and when we get enough changes in > that branch we cut it and make a 2.17.1 release. > > You need release manager ACK though, which is David Miller. We normally > handle backports via bugzilla bugs with keyword glibc_2.17, but it > can be less formal if you just CC David and ask for ACK. David, is it OK if I backport this to the 2.17 branch after I commit? Do you want a BZ# to track it? -- Chris Metcalf, Tilera Corp. http://www.tilera.com