From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11744 invoked by alias); 9 Jun 2013 15:22:38 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 11735 invoked by uid 89); 9 Jun 2013 15:22:37 -0000 X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.1 Received: from usmamail.tilera.com (HELO USMAMAIL.TILERA.COM) (12.216.194.151) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sun, 09 Jun 2013 15:22:37 +0000 Received: from [192.168.1.101] (98.217.155.22) by USMAExch2.tad.internal.tilera.com (10.3.0.33) with Microsoft SMTP Server id 14.0.722.0; Sun, 9 Jun 2013 11:22:34 -0400 Message-ID: <51B49DB9.8070606@tilera.com> Date: Sun, 09 Jun 2013 15:22:00 -0000 From: Chris Metcalf User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: David Miller CC: Subject: Re: [PATCH] tile: improve detection for missing -mcmodel=large support References: <519ECAF3.1040700@tilera.com> <51A4F980.3040309@tilera.com> <51B0ECC9.2060903@tilera.com> <20130606.143637.1233536179323434136.davem@davemloft.net> In-Reply-To: <20130606.143637.1233536179323434136.davem@davemloft.net> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00011.txt.bz2 On 6/6/2013 5:36 PM, David Miller wrote: > From: Chris Metcalf > Date: Thu, 6 Jun 2013 16:10:49 -0400 > >> Ping! for David Miller. > This is fine to backport to 2.17, thanks. Pushed to release/2.17/master as 201b499c978b, thanks. >> On 5/28/2013 2:37 PM, Chris Metcalf wrote: >>> I pushed this to master. "Ping" for David Miller to comment on 2.17 acceptability. Thanks! >>> >>> On 5/23/2013 10:05 PM, Chris Metcalf wrote: >>>> (Adding David explicitly to Cc.) >>>> >>>> On 5/23/2013 6:17 PM, Carlos O'Donell wrote: >>>>> On 05/23/2013 03:20 PM, Chris Metcalf wrote: >>>>>> The existing test avoided passing -mcmodel=large if the compiler didn't >>>>>> support it. However, we need to test not just the compiler support, but >>>>>> also the toolchain (as and ld) support, so make the test more complete. >>>>>> In addition, we have to avoid using the hwN_plt() assembly operators if >>>>>> that support is missing, so guard the uses with #ifdef NO_PLT_PCREL. >>>>>> >>>>>> This allows us to properly build glibc with the current community >>>>>> binutils, which doesn't yet have the PC-relative PLT operator support. >>>>>> The -mcmodel=large support is in gcc 4.8, but the toolchain support >>>>>> won't be present in the community until binutils 2.24. >>>>>> --- >>>>>> This change should also be applied on the 2.17 release branch for >>>>>> when we release a 2.17.1. >>>>> No, just backport it immediately after checkin to master. The 2.17 >>>>> branch *is* 2.17.1 in development and when we get enough changes in >>>>> that branch we cut it and make a 2.17.1 release. >>>>> >>>>> You need release manager ACK though, which is David Miller. We normally >>>>> handle backports via bugzilla bugs with keyword glibc_2.17, but it >>>>> can be less formal if you just CC David and ask for ACK. >>>> David, is it OK if I backport this to the 2.17 branch after I commit? Do you want a BZ# to track it? -- Chris Metcalf, Tilera Corp. http://www.tilera.com