From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28761 invoked by alias); 9 Jun 2013 18:51:34 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 28700 invoked by uid 89); 9 Jun 2013 18:51:26 -0000 X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,FRT_OFFER2,KHOP_THREADED,SPF_PASS autolearn=no version=3.3.1 X-Spam-User: qpsmtpd, 2 recipients Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sun, 09 Jun 2013 18:51:16 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0CFAFA3B99; Sun, 9 Jun 2013 20:51:13 +0200 (CEST) Message-ID: <51B4CE90.3000002@suse.com> Date: Sun, 09 Jun 2013 18:51:00 -0000 From: Andreas Jaeger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: "Joseph S. Myers" Cc: libc-alpha@sourceware.org, libc-ports@sourceware.org Subject: Re: Add rounding mode information to math-tests.h and use it in libm-test.inc References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-06/txt/msg00012.txt.bz2 On 06/04/2013 09:26 PM, Joseph S. Myers wrote: > The lists of known testsuite failures for ARM and MIPS include various > tests failing in circumstances when rounding modes or exceptions > support is not available at runtime. > > In line with the principle of trying to have zero failures as the > expected testsuite state, this patch adds macros to math-tests.h to > say when testing of a rounding mode should be disabled despite > fesetround succeeding, and makes libm-test.inc use them, with > definitions being added for ARM; similar macros will also be needed to > indicate when support for exceptions is available, and the macros will > need using in other tests. These macros will also be usable for MIPS, > to describe the situation there where MIPS64 long double (IEEE quad) > is implemented in libgcc using soft-fp without support for exceptions > or rounding modes, even when float and double use hardware floating > point. > > (fesetround passing but not properly affecting all types is of course > a bug, but one only fixable in libgcc - by using IFUNC there in the > ARM case to make __aeabi_* use VFP when available at runtime, by using > soft-fp instead of fp-bit in the MIPS case. Disabling the tests here > is similar to the existing handling of sNaN tests; if the GCC issues > are fixed, the math-tests.h definitions can be made conditional on the > GCC version. Macros indicating when exception support is expected to > be missing will still be relevant even with fixed libgcc.) > > Tested on an affected ARM configuration that the non-default > rounding-mode tests from libm-test.inc are no longer run with this > patch applied. Thanks, this looks fine to me, Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126