From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18448 invoked by alias); 3 Jul 2013 20:42:22 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 18420 invoked by uid 89); 3 Jul 2013 20:42:18 -0000 X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.1 Received: from usmamail.tilera.com (HELO USMAMAIL.TILERA.COM) (12.216.194.151) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 03 Jul 2013 20:42:11 +0000 Received: from [10.7.0.95] (10.9.0.23) by USMAExch2.tad.internal.tilera.com (10.3.0.33) with Microsoft SMTP Server id 14.0.722.0; Wed, 3 Jul 2013 16:42:09 -0400 Message-ID: <51D48CA1.6080100@tilera.com> Date: Wed, 03 Jul 2013 20:42:00 -0000 From: Chris Metcalf User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: Carlos O'Donell CC: Subject: Re: [PATCH] tile: use _dl_static_init to set GLRO(gl_pagesize) References: <201307032021.r63KL9GS007940@farm-0002.internal.tilera.com> <51D48ADD.50105@redhat.com> In-Reply-To: <51D48ADD.50105@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-SW-Source: 2013-07/txt/msg00020.txt.bz2 On 7/3/2013 4:34 PM, Carlos O'Donell wrote: > On 07/03/2013 02:48 PM, Chris Metcalf wrote: >> A recently-added test (dlfcn/tststatic5) pointed out that tile was not >> properly initializing the variable pagesize in certain cases. This >> change just copies the existing code from MIPS. >> --- >> I assume this change can be committed to master for inclusion in 2.18, >> as it fixes a (new) testsuite failure? > Yes. > > Bug fixes (not new features) are the whole point of the freeze ;-) > > If you have something that's a bit of both you need to include > the release manager (David Miller) and argue your point. I'm comfortable that this one is a pure bug fix. -- Chris Metcalf, Tilera Corp. http://www.tilera.com