From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31694 invoked by alias); 18 Aug 2013 22:31:07 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 31676 invoked by uid 89); 18 Aug 2013 22:31:06 -0000 X-Spam-SWARE-Status: No, score=-6.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_MED,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients Received: from gerolde.archlinux.org (HELO gerolde.archlinux.org) (66.211.214.132) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sun, 18 Aug 2013 22:31:05 +0000 Received: from [10.1.1.2] (122-148-115-77.static.dsl.dodo.com.au [122.148.115.77]) by gerolde.archlinux.org (Postfix) with ESMTPSA id 43BDC906FF; Sun, 18 Aug 2013 18:31:02 -0400 (EDT) Message-ID: <52114B22.3090902@archlinux.org> Date: Sun, 18 Aug 2013 22:31:00 -0000 From: Allan McRae User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130806 Thunderbird/17.0.8 MIME-Version: 1.0 To: =?UTF-8?B?T25kxZllaiBCw61sa2E=?= CC: "Joseph S. Myers" , libc-alpha@sourceware.org, libc-ports@sourceware.org Subject: Re: [PATCH 1/9] Fix typos. References: <20130813082629.GA27180@domone.kolej.mff.cuni.cz> <20130818164943.GA7418@domone> <20130818220954.GA20381@domone> In-Reply-To: <20130818220954.GA20381@domone> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2013-08/txt/msg00014.txt.bz2 On 19/08/13 08:09, Ondřej Bílka wrote: > On Sun, Aug 18, 2013 at 08:15:24PM +0000, Joseph S. Myers wrote: >> I stopped commenting here. For any subsequent revisions, in addition to >> the points I identified above, please keep patches down to at most 1000 >> lines for convenience of review, and wait until consensus has been reached >> on a single posted patch before sending any subsequent patches (also of at >> most 1000 lines). >> > I split patches to 1000 lines, here is first one. > This is the only one that I think needs fixed as there was more than just a typo going on there. > diff --git a/iconv/skeleton.c b/iconv/skeleton.c > index 45beb06..6997e05 100644 > --- a/iconv/skeleton.c > +++ b/iconv/skeleton.c > @@ -514,7 +514,7 @@ FUNCTION_NAME (struct __gconv_step *step, struct __gconv_step_data *data, > size_t *lirreversiblep = irreversible ? &lirreversible : NULL; > > /* The following assumes that encodings, which have a variable length > - what might unalign a buffer even though it is a aligned in the > + what might unalign a buffer even though it is an aligned in the > beginning, either don't have the minimal number of bytes as a divisor > of the maximum length or have a minimum length of 1. This is true > for all known and supported encodings.