From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20473 invoked by alias); 29 Aug 2013 04:17:06 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 20463 invoked by uid 89); 29 Aug 2013 04:17:06 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Aug 2013 04:17:06 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7T4H1O5026628 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 29 Aug 2013 00:17:01 -0400 Received: from [10.3.113.100] (ovpn-113-100.phx2.redhat.com [10.3.113.100]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r7T4GwXv018882; Thu, 29 Aug 2013 00:17:00 -0400 Message-ID: <521ECB3A.4040209@redhat.com> Date: Thu, 29 Aug 2013 04:17:00 -0000 From: "Carlos O'Donell" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: "Joseph S. Myers" CC: "libc-ports@sourceware.org" , Kyle McMartin Subject: Re: [PATCH] arm: Fix R_ARM_IRELATIVE for REL relocs. References: <521D7B45.5040604@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00057.txt.bz2 On 08/28/2013 12:14 PM, Joseph S. Myers wrote: > On Wed, 28 Aug 2013, Carlos O'Donell wrote: > >> 2013-08-28 Kyle McMartin >> Carlos O'Donell >> >> * sysdeps/arm/dl-machine [!RTLD_BOOTSTRAP] (elf_machine_rel): >> Pass GLRO(dl_hwcap) to the IFUNC resolver. > > OK, given a bug filed in Bugzilla and a corresponding [BZ #N] notation and > entry in NEWS for the fixed bug. I created BZ# 15905. Sorry for forgetting, and thanks for reminding me. I've checked in the patch which fixes the failures we're seeing in Fedora on this hardware. > Have you verified that all ARM instances > of such code now consistently pass the HWCAP value? Yes. There are 4 places that require dl_hwcap to be used: * ifunc-impl-list.c (__libc_ifunc_impl_list) - Already uses dl_hwcap. * dl-irel.h (elf_ifunc_invoke) - Already uses dl_hwcap. Was fixed by Richard Henderson in commit 73da6bacf (along with other instances in dl-machine.h). * dl-machine.h (elf_machine_rel) - Fixed by this patch. * dl-machine.h (elf_machine_rela) - Fixed by Will Newton's patch. These are the only place that I know about that require using dl_hwcap and all of them are now fixed. The uses are inconsistent in their use of `unsigned long int' vs. 'int' for the dl_hwcap parameter, but changing that could be a future cleanup. I will note that the 32-bit ARM testsuite on this hardware is not clean e.g. make[2]: *** [/home/codonell/build/math/test-fenv.out] Error 1 make[1]: *** [math/tests] Error 2 make[2]: *** [/home/codonell/build/stdio-common/bug22.out] Error 1 make[1]: *** [stdio-common/tests] Error 2 make[2]: [/home/codonell/build/posix/annexc.out] Error 1 (ignored) make[2]: *** [/home/codonell/build/nptl/tst-cleanup2.out] Error 1 make[2]: *** [/home/codonell/build/nptl/tst-cleanupx2.out] Error 1 make[1]: *** [nptl/tests] Error 2 make[2]: [/home/codonell/build/conform/run-conformtest.out] Error 1 (ignored) make[2]: *** [/home/codonell/build/elf/ifuncmain5picstatic.out] Error 139 make[1]: *** [elf/tests] Error 2 make[1]: *** [/home/codonell/build/check-local-headers.out] Error 1 make: *** [check] Error 2 In particular ifuncmain5picstatic.out looks troublesome, and I need to look at it to see if something is further wrong with the IFUNC support. Cheers, Carlos.