From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20106 invoked by alias); 30 Aug 2013 17:35:12 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 20094 invoked by uid 89); 30 Aug 2013 17:35:12 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Aug 2013 17:35:12 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.6 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7UHZ7a2001563 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 30 Aug 2013 13:35:07 -0400 Received: from [10.3.113.180] (ovpn-113-180.phx2.redhat.com [10.3.113.180]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7UHZ695027994; Fri, 30 Aug 2013 13:35:06 -0400 Message-ID: <5220D7C9.7080707@redhat.com> Date: Fri, 30 Aug 2013 17:35:00 -0000 From: "Carlos O'Donell" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 MIME-Version: 1.0 To: Will Newton CC: "Joseph S. Myers" , "libc-ports@sourceware.org" , Patch Tracking Subject: Re: [PATCH] ARM: Fix clone code when built for Thumb. References: <521F9E4E.5040906@linaro.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00089.txt.bz2 On 08/30/2013 06:18 AM, Will Newton wrote: > On 29 August 2013 20:26, Joseph S. Myers wrote: >> On Thu, 29 Aug 2013, Will Newton wrote: >> >>> The mov lr, pc instruction will lose the Thumb bit from the return address >>> so use blx lr instead. >>> >>> ports/ChangeLog.arm: >>> >>> 2013-08-29 Will Newton >>> >>> * sysdeps/unix/sysv/linux/arm/clone.S (__clone): Use blx >>> instead of mov lr, pc. >> >> OK given a bug filed in Bugzilla and appropriate [BZ #N] notation and >> addition of the fixed bug number to NEWS. Since this is a regression >> arising from the changes to build .S files as Thumb, you should also >> cherry-pick the fix to 2.18 branch. > > Committed to master and the 2.18 branch. Let me know if I missed anything. Please be aware that the release manager for 2.18 should be ACK'ing your patches going into 2.18 (David Miller). David is responsible for the branch and it's his responsibility if the branch gets into a bad state. You can make it easy for David by stating that Joseph said it's OK, and explaining your testing. Cheers, Carlos.