public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: "Carlos O'Donell" <carlos@redhat.com>
To: Will Newton <will.newton@linaro.org>
Cc: "Joseph S. Myers" <joseph@codesourcery.com>,
	       "libc-ports@sourceware.org" <libc-ports@sourceware.org>,
	       Patch Tracking <patches@linaro.org>
Subject: Re: [PATCH] sysdeps/arm/armv6t2/strlen.S: strlen implementation for armv6t2.
Date: Fri, 30 Aug 2013 17:36:00 -0000	[thread overview]
Message-ID: <5220D827.50800@redhat.com> (raw)
In-Reply-To: <CANu=DmjLyGRdmvPABiDJMuPM4YyH=p8QrpvNgQpNiH3-LqXOkg@mail.gmail.com>

On 08/30/2013 05:06 AM, Will Newton wrote:
> On 30 August 2013 01:13, Joseph S. Myers <joseph@codesourcery.com> wrote:
>> On Mon, 12 Aug 2013, Will Newton wrote:
>>
>>> This implementation of strlen is faster than the armv6 version for
>>> all string lengths greater than 1 on a Cortex-A15.
>>>
>>> ports/ChangeLog.arm:
>>>
>>> 2013-08-09  Will Newton  <will.newton@linaro.org>
>>>
>>>       * sysdeps/arm/armv6t2/strlen.S: New file.
>>
>> OK, presuming you've run the full glibc testsuite with this version used.
> 
> Yes, testsuite is clean. Committed.

I'm not happy seeing these kinds of patches go in without some
kind of numbers around "faster" and a reproducible way to get
those numbers.

Cheers,
Carlos.
 

  reply	other threads:[~2013-08-30 17:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-12  7:56 Will Newton
2013-08-27  7:47 ` Will Newton
2013-08-30  0:13 ` Joseph S. Myers
2013-08-30  9:06   ` Will Newton
2013-08-30 17:36     ` Carlos O'Donell [this message]
2013-08-30 17:38       ` Carlos O'Donell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5220D827.50800@redhat.com \
    --to=carlos@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-ports@sourceware.org \
    --cc=patches@linaro.org \
    --cc=will.newton@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).