public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: "Carlos O'Donell" <carlos@redhat.com>
To: Steve Ellcey <sellcey@mips.com>
Cc: libc-ports@sourceware.org
Subject: Re: [patch, mips] Improved memset for MIPS
Date: Tue, 10 Sep 2013 22:38:00 -0000	[thread overview]
Message-ID: <522F9F45.5070800@redhat.com> (raw)
In-Reply-To: <522F9E95.9030205@redhat.com>

On 09/10/2013 06:35 PM, Carlos O'Donell wrote:
> On 09/10/2013 05:12 PM, Steve Ellcey wrote:
>> On Tue, 2013-09-10 at 17:01 -0400, Carlos O'Donell wrote:
>>
>>>> Now that I can see the results of 'make bench' I do have a question,
>>>> what is the difference between the results in bench-memset.out and
>>>> bench-memset-ifunc.out?  MIPS doesn't yet support IFUNC.  It looks like
>>>> the results in the two files are pretty close, so maybe they are
>>>> identical runs on machines with no IFUNC?
>>>
>>> You get the default implementation of __libc_ifunc_impl_list (the function
>>> used by the testing infrastructure to iterate the functions implemented
>>> as ifuncs) which adds no additional functions to the test list. You still
>>> test the usual defaults e.g. simple, builtin, and original function entry.
>>> Therefore it's the same as the non-IFUNC version with the results being
>>> the same modulo testing variance.
>>>
>>> Does that answer your question?
>>
>> I think so, but just to be clear: If I did have IFUNC and 4 different
>> implementations of memset (for example), would the testing
>> infrastructure run and benchmark all 4 versions of memset?
> 
> Yes.

Modulo hardware support obviously.

All IFUNC functions are registered at runtime with a "usable"
flag indicating if the present hardware can run that function.

The test infrastucture uses "usable" to decide to test that
function or not.

Cheers,
Carlos.

  reply	other threads:[~2013-09-10 22:38 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-05 17:06 Steve Ellcey 
2013-09-06  0:40 ` Mike Frysinger
2013-09-06 15:42   ` Steve Ellcey
2013-09-06  4:18 ` Carlos O'Donell
2013-09-06 16:03   ` Steve Ellcey
2013-09-06 17:12     ` Carlos O'Donell
2013-09-06 23:33       ` Steve Ellcey
2013-09-07  2:38         ` Carlos O'Donell
2013-09-10 20:31           ` Steve Ellcey
2013-09-10 21:01             ` Carlos O'Donell
2013-09-10 21:14               ` Steve Ellcey
2013-09-10 22:35                 ` Carlos O'Donell
2013-09-10 22:38                   ` Carlos O'Donell [this message]
2013-09-07  5:46         ` Andreas Schwab
2013-09-06 14:31 ` Joseph S. Myers
2013-09-06 15:58   ` Steve Ellcey
2013-09-06 16:09     ` Joseph S. Myers
2013-09-06 16:50       ` Steve Ellcey
2013-09-06 16:59         ` Joseph S. Myers
2013-09-06 17:43           ` Steve Ellcey
2013-09-06 18:57             ` Brooks Moses
2013-09-18 17:41           ` Steve Ellcey
2013-09-19 15:25             ` Carlos O'Donell
2013-09-19 17:02               ` Steve Ellcey
2013-09-20 16:43             ` Joseph S. Myers
2013-09-20 17:32               ` Steve Ellcey
2013-12-12 22:19                 ` Andrew Pinski
2013-12-13  0:01                   ` Carlos O'Donell
2013-12-13  0:14                     ` Steve Ellcey
2013-12-13  0:22                       ` Andrew Pinski
2013-12-13  4:40                       ` Carlos O'Donell
2013-09-06 16:59       ` Steve Ellcey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=522F9F45.5070800@redhat.com \
    --to=carlos@redhat.com \
    --cc=libc-ports@sourceware.org \
    --cc=sellcey@mips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).