public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: "Carlos O'Donell" <carlos@redhat.com>
To: Steve Ellcey <sellcey@mips.com>
Cc: "Joseph S. Myers" <joseph@codesourcery.com>, libc-ports@sourceware.org
Subject: Re: [patch, mips] Improved memset for MIPS
Date: Thu, 19 Sep 2013 15:25:00 -0000	[thread overview]
Message-ID: <523B175D.2000408@redhat.com> (raw)
In-Reply-To: <1379526035.5770.414.camel@ubuntu-sellcey>

On 09/18/2013 01:40 PM, Steve Ellcey wrote:
> Here is an updated version of my new MIPS memset.S routine.  I fixed the
> format of the comments and the ifdef indenting and I ran 'make check'
> and 'make bench' on little endian and big endian systems with the o32,
> n32, and n64 ABIs.  The testing did find a bug that my original testing
> missed and I have fixed that bug (it involved a negative value as the
> constant being set).  Other then that, the only failures I saw were the
> expected check-localplt and check-execstack errors.
> 
> I don't know if you want to see all the performance results from
> bench-memset.out since it has a lot of output, but looking at the
> average time for 131072 byte memsets, the original libc in o32 little
> endian mode averaged 43732 (seconds I guess) and the new one was
> 27365.  n32 went from 21886 to 21881 and n64 went from 21882 to 21877.
> So the 64 bit numbers only improved a little, but the 32 bit version
> shows a very nice improvement.
> 
> Steve Ellcey
> sellcey@mips.com
> 
> 
> 2013-09-18  Steve Ellcey  <sellcey@mips.com>
> 
> 	* sysdeps/mips/memset.S: Change prefetching and add loop unrolling. 
> 	* sysdeps/mips/mips64/memset.S: Remove.
> 

This looks good to me.

I think Joseph Myers should give the final ACK.

Could you please post your *.out files so others 
can have the raw data for the test run?

Cheers,
Carlos.

  reply	other threads:[~2013-09-19 15:25 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-05 17:06 Steve Ellcey 
2013-09-06  0:40 ` Mike Frysinger
2013-09-06 15:42   ` Steve Ellcey
2013-09-06  4:18 ` Carlos O'Donell
2013-09-06 16:03   ` Steve Ellcey
2013-09-06 17:12     ` Carlos O'Donell
2013-09-06 23:33       ` Steve Ellcey
2013-09-07  2:38         ` Carlos O'Donell
2013-09-10 20:31           ` Steve Ellcey
2013-09-10 21:01             ` Carlos O'Donell
2013-09-10 21:14               ` Steve Ellcey
2013-09-10 22:35                 ` Carlos O'Donell
2013-09-10 22:38                   ` Carlos O'Donell
2013-09-07  5:46         ` Andreas Schwab
2013-09-06 14:31 ` Joseph S. Myers
2013-09-06 15:58   ` Steve Ellcey
2013-09-06 16:09     ` Joseph S. Myers
2013-09-06 16:50       ` Steve Ellcey
2013-09-06 16:59         ` Joseph S. Myers
2013-09-06 17:43           ` Steve Ellcey
2013-09-06 18:57             ` Brooks Moses
2013-09-18 17:41           ` Steve Ellcey
2013-09-19 15:25             ` Carlos O'Donell [this message]
2013-09-19 17:02               ` Steve Ellcey
2013-09-20 16:43             ` Joseph S. Myers
2013-09-20 17:32               ` Steve Ellcey
2013-12-12 22:19                 ` Andrew Pinski
2013-12-13  0:01                   ` Carlos O'Donell
2013-12-13  0:14                     ` Steve Ellcey
2013-12-13  0:22                       ` Andrew Pinski
2013-12-13  4:40                       ` Carlos O'Donell
2013-09-06 16:59       ` Steve Ellcey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=523B175D.2000408@redhat.com \
    --to=carlos@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-ports@sourceware.org \
    --cc=sellcey@mips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).