From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21521 invoked by alias); 19 Sep 2013 15:25:26 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 21508 invoked by uid 89); 19 Sep 2013 15:25:25 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Sep 2013 15:25:25 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8JFPJuh000914 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 19 Sep 2013 11:25:19 -0400 Received: from [10.3.113.73] (ovpn-113-73.phx2.redhat.com [10.3.113.73]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r8JFPHra026771; Thu, 19 Sep 2013 11:25:18 -0400 Message-ID: <523B175D.2000408@redhat.com> Date: Thu, 19 Sep 2013 15:25:00 -0000 From: "Carlos O'Donell" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 MIME-Version: 1.0 To: Steve Ellcey CC: "Joseph S. Myers" , libc-ports@sourceware.org Subject: Re: [patch, mips] Improved memset for MIPS References: <93a232b5-9d0b-4a27-bbb5-16e3ae7c4b89@BAMAIL02.ba.imgtec.org> <1378483039.5770.302.camel@ubuntu-sellcey> <1378486241.5770.327.camel@ubuntu-sellcey> <1379526035.5770.414.camel@ubuntu-sellcey> In-Reply-To: <1379526035.5770.414.camel@ubuntu-sellcey> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00106.txt.bz2 On 09/18/2013 01:40 PM, Steve Ellcey wrote: > Here is an updated version of my new MIPS memset.S routine. I fixed the > format of the comments and the ifdef indenting and I ran 'make check' > and 'make bench' on little endian and big endian systems with the o32, > n32, and n64 ABIs. The testing did find a bug that my original testing > missed and I have fixed that bug (it involved a negative value as the > constant being set). Other then that, the only failures I saw were the > expected check-localplt and check-execstack errors. > > I don't know if you want to see all the performance results from > bench-memset.out since it has a lot of output, but looking at the > average time for 131072 byte memsets, the original libc in o32 little > endian mode averaged 43732 (seconds I guess) and the new one was > 27365. n32 went from 21886 to 21881 and n64 went from 21882 to 21877. > So the 64 bit numbers only improved a little, but the 32 bit version > shows a very nice improvement. > > Steve Ellcey > sellcey@mips.com > > > 2013-09-18 Steve Ellcey > > * sysdeps/mips/memset.S: Change prefetching and add loop unrolling. > * sysdeps/mips/mips64/memset.S: Remove. > This looks good to me. I think Joseph Myers should give the final ACK. Could you please post your *.out files so others can have the raw data for the test run? Cheers, Carlos.