From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32172 invoked by alias); 27 Sep 2013 01:43:32 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 32144 invoked by uid 89); 27 Sep 2013 01:43:31 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 27 Sep 2013 01:43:31 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_40,RP_MATCHES_RCVD,SPAM_SUBJECT autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8R1gxqG000852 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 26 Sep 2013 21:43:00 -0400 Received: from [10.3.113.8] ([10.3.113.8]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r8R1gweW007192; Thu, 26 Sep 2013 21:42:59 -0400 Message-ID: <5244E2A2.7020405@redhat.com> Date: Fri, 27 Sep 2013 01:43:00 -0000 From: "Carlos O'Donell" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 MIME-Version: 1.0 To: Kaz Kojima CC: libc-ports@sourceware.org, thomas@codesourcery.com Subject: Re: All machines: Pointer guard testing update (Bug 15754, CVE-2013-4788). References: <52444A27.7050500@redhat.com> <20130927.100635.215380609.kkojima@rr.iij4u.or.jp> In-Reply-To: <20130927.100635.215380609.kkojima@rr.iij4u.or.jp> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00148.txt.bz2 On 09/26/2013 09:06 PM, Kaz Kojima wrote: > Hi, > > "Carlos O'Donell" wrote: >> My request is that you run the testsuite and verify that >> tst-ptrguard1 and tst-ptrguard1-static pass. If they don't >> pass please email me and we can work out what might be >> wrong with your POINTER_CHK_GUARD implementation. > > New ptrguard tests fail on SH because the target uses generic > stackguard-macros.h but defines THREAD_SET_POINTER_GUARD. > The attached patch works for me. > > Regards, > kaz > -- > * sysdeps/sh/stackguard-macros.h: New file. > > diff --git a/sysdeps/sh/stackguard-macros.h b/sysdeps/sh/stackguard-macros.h > new file mode 100644 > index 0000000..55a5771 > --- /dev/null > +++ b/sysdeps/sh/stackguard-macros.h > @@ -0,0 +1,6 @@ > +#include > + > +extern uintptr_t __stack_chk_guard; > +#define STACK_CHK_GUARD __stack_chk_guard > + > +#define POINTER_CHK_GUARD THREAD_GET_POINTER_GUARD() > Kaz, That looks good to me. I will admit that's not a combination I thought about. Thanks for fixing it. Cheers, Carlos.