From: Allan McRae <allan@archlinux.org>
To: Russ Allbery <rra@stanford.edu>,
libc-alpha@sourceware.org, libc-ports@sourceware.org,
Mike Frysinger <vapier@gentoo.org>
Subject: Re: [PATCH] rename configure.in to configure.ac
Date: Wed, 16 Oct 2013 03:31:00 -0000 [thread overview]
Message-ID: <525E08A1.9090204@archlinux.org> (raw)
In-Reply-To: <8738pia1bg.fsf@windlord.stanford.edu>
On 06/09/13 16:53, Russ Allbery wrote:
> Mike Frysinger <vapier@gentoo.org> writes:
>
>> Autoconf has been deprecating configure.in for quite a long time.
>> Rename all our configure.in and preconfigure.in files to .ac.
>
> This is almost certainly perfectly fine, and I haven't looked at context,
> but I wanted to make sure that someone had noticed it:
>
>> diff --git a/configure b/configure
>> index 2122583..e9c2827 100755
>> --- a/configure
>> +++ b/configure
>> @@ -5171,7 +5171,7 @@ $as_echo_n "checking whether $AUTOCONF${ACFLAGS:+ }$ACFLAGS works... " >&6; }
>> if ${libc_cv_autoconf_works+:} false; then :
>> $as_echo_n "(cached) " >&6
>> else
>> - if (cd $srcdir; $AUTOCONF $ACFLAGS configure.in > /dev/null 2>&1); then
>> + if (cd $srcdir; $AUTOCONF $ACFLAGS configure.ac > /dev/null 2>&1); then
>> libc_cv_autoconf_works=yes
>> else
>> libc_cv_autoconf_works=no
>> @@ -8801,7 +8801,7 @@ ac_abs_srcdir=$ac_abs_top_srcdir$ac_dir_suffix
>> ac_sub_configure=$ac_srcdir/configure.gnu
>> elif test -f "$ac_srcdir/configure"; then
>> ac_sub_configure=$ac_srcdir/configure
>> - elif test -f "$ac_srcdir/configure.in"; then
>> + elif test -f "$ac_srcdir/configure.ac"; then
>> # This should be Cygnus configure.
>> ac_sub_configure=$ac_aux_dir/configure
>> else
>
> I believe the renaming of configure.in to configure.ac is specific to
> Autoconf. Cygnus configure is a different (and older) beast; if anyone is
> actually still using Cygnus configure, those files would still be named
> configure.in, not configure.ac.
>
Correct. In fact, rerunning autoconf changes thus line back to using
configure.in.
Patch is good for me with that change.
Allan
next prev parent reply other threads:[~2013-10-16 3:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 0:07 Mike Frysinger
2013-09-06 5:28 ` Carlos O'Donell
2013-09-06 6:53 ` Russ Allbery
2013-10-16 3:31 ` Allan McRae [this message]
2013-10-26 6:24 ` Allan McRae
2013-10-28 23:07 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525E08A1.9090204@archlinux.org \
--to=allan@archlinux.org \
--cc=libc-alpha@sourceware.org \
--cc=libc-ports@sourceware.org \
--cc=rra@stanford.edu \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).