From: Chung-Lin Tang <cltang@codesourcery.com>
To: Andrew Pinski <pinskia@gmail.com>
Cc: "libc-ports@sourceware.org" <libc-ports@sourceware.org>,
Chris Metcalf <cmetcalf@tilera.com>
Subject: Re: struct statfs/statfs64 in linux-generic
Date: Tue, 05 Nov 2013 04:23:00 -0000 [thread overview]
Message-ID: <527872B5.5080200@codesourcery.com> (raw)
In-Reply-To: <CA+=Sn1m7102-LJg8ee-ZchCaSLF1iPQKegQW6J59XS8HbX0qOg@mail.gmail.com>
On 2013/11/4 04:19 PM, Andrew Pinski wrote:
> --- a/ports/sysdeps/unix/sysv/linux/aarch64/bits/typesizes.h
> +++ b/ports/sysdeps/unix/sysv/linux/aarch64/bits/typesizes.h
> @@ -53,7 +53,7 @@
> #define __FSBLKCNT64_T_TYPE __UQUAD_TYPE
> #define __FSFILCNT_T_TYPE __ULONGWORD_TYPE
> #define __FSFILCNT64_T_TYPE __UQUAD_TYPE
> -#define __FSWORD_T_TYPE __SWORD_TYPE
> +#define __FSWORD_T_TYPE __SYSCALL_SLONG_TYPE
> #define __ID_T_TYPE __U32_TYPE
> #define __CLOCK_T_TYPE __SYSCALL_SLONG_TYPE
> #define __TIME_T_TYPE __SYSCALL_SLONG_TYPE
I'm guessing you re-defined __SYSCALL_SLONG_TYPE to a 64-bit signed type
as well? The default seems to be __SLONGWORD_TYPE, which is a 4-byte
long int.
Still, I'm not sure if using full 64-bit fields should be the intended
solution. A full 32-bit target should be able to have those fields as
32-bit (which means a kernel patch to differentiate the current uses of
'__statfs_word' into 32/64-bit words)
Chung-Lin
next prev parent reply other threads:[~2013-11-05 4:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 7:18 Chung-Lin Tang
2013-11-04 8:19 ` Andrew Pinski
2013-11-05 4:23 ` Chung-Lin Tang [this message]
2013-11-07 19:55 ` Chris Metcalf
2013-11-10 8:24 ` Chung-Lin Tang
2013-11-11 17:48 ` Joseph S. Myers
2013-11-13 8:17 ` Chung-Lin Tang
2013-11-13 12:59 ` Joseph S. Myers
2013-11-14 4:34 ` Chung-Lin Tang
2013-11-14 13:36 ` Joseph S. Myers
2013-11-14 18:28 ` Chris Metcalf
2013-11-15 7:39 ` Chung-Lin Tang
2013-11-18 23:39 ` Chris Metcalf
2013-11-19 13:50 ` Chung-Lin Tang
2013-11-22 2:43 ` Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527872B5.5080200@codesourcery.com \
--to=cltang@codesourcery.com \
--cc=cmetcalf@tilera.com \
--cc=libc-ports@sourceware.org \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).