From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2416 invoked by alias); 5 Nov 2013 04:23:34 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 2402 invoked by uid 89); 5 Nov 2013 04:23:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Nov 2013 04:23:32 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1VdYAf-00074s-6S from ChungLin_Tang@mentor.com ; Mon, 04 Nov 2013 20:23:17 -0800 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 4 Nov 2013 20:23:16 -0800 Received: from [0.0.0.0] (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.2.247.3; Mon, 4 Nov 2013 20:23:16 -0800 Message-ID: <527872B5.5080200@codesourcery.com> Date: Tue, 05 Nov 2013 04:23:00 -0000 From: Chung-Lin Tang User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Andrew Pinski CC: "libc-ports@sourceware.org" , Chris Metcalf Subject: Re: struct statfs/statfs64 in linux-generic References: <52774A2F.5010505@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00003.txt.bz2 On 2013/11/4 04:19 PM, Andrew Pinski wrote: > --- a/ports/sysdeps/unix/sysv/linux/aarch64/bits/typesizes.h > +++ b/ports/sysdeps/unix/sysv/linux/aarch64/bits/typesizes.h > @@ -53,7 +53,7 @@ > #define __FSBLKCNT64_T_TYPE __UQUAD_TYPE > #define __FSFILCNT_T_TYPE __ULONGWORD_TYPE > #define __FSFILCNT64_T_TYPE __UQUAD_TYPE > -#define __FSWORD_T_TYPE __SWORD_TYPE > +#define __FSWORD_T_TYPE __SYSCALL_SLONG_TYPE > #define __ID_T_TYPE __U32_TYPE > #define __CLOCK_T_TYPE __SYSCALL_SLONG_TYPE > #define __TIME_T_TYPE __SYSCALL_SLONG_TYPE I'm guessing you re-defined __SYSCALL_SLONG_TYPE to a 64-bit signed type as well? The default seems to be __SLONGWORD_TYPE, which is a 4-byte long int. Still, I'm not sure if using full 64-bit fields should be the intended solution. A full 32-bit target should be able to have those fields as 32-bit (which means a kernel patch to differentiate the current uses of '__statfs_word' into 32/64-bit words) Chung-Lin