public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Matt Turner <mattst88@gmail.com>, libc-ports@sourceware.org
Cc: Uros Bizjak <ubizjak@gmail.com>,
	Mike Frysinger <vapier@gentoo.org>,
	 Gentoo alpha AT <alpha@gentoo.org>
Subject: Re: Signal handling broken on alpha since glibc-2.16
Date: Wed, 13 Nov 2013 22:52:00 -0000	[thread overview]
Message-ID: <52840226.4010801@twiddle.net> (raw)
In-Reply-To: <CAEdQ38FPugwGndv9szKjuM82e5dBr2FKDfrq4CMoP1N_ax8Sqg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

On 11/04/2013 11:10 AM, Matt Turner wrote:
> A test from the gcc test suite shows that signal handling is broken on
> alpha since glibc-2.16. Bisecting before the glibc-ports merge is
> rather hard.
> 
> See: https://bugs.gentoo.org/show_bug.cgi?id=480740 (includes test case)
> 
> Off hand, do any changes between 2.15 and 2.16 seem to be likely
> candidates to cause this bug?

It's likely to be change 7d1feb5693be7e606104cc2b6657c746a93e5926.

Please try this.


r~

[-- Attachment #2: zz --]
[-- Type: text/plain, Size: 818 bytes --]

diff --git a/ports/sysdeps/unix/sysv/linux/alpha/rt_sigaction.S b/ports/sysdeps/unix/sysv/linux/alpha/rt_sigaction.S
index 3d291fd..bd55418 100644
--- a/ports/sysdeps/unix/sysv/linux/alpha/rt_sigaction.S
+++ b/ports/sysdeps/unix/sysv/linux/alpha/rt_sigaction.S
@@ -83,14 +83,15 @@ PSEUDO_END(__syscall_rt_sigaction)
 	cfi_offset (64, \base + 2 * 8)
 	.endm
 
-	.align	4
-
 	cfi_startproc
 	cfi_return_column (64)
 	.cfi_signal_frame
 	SIGCONTEXT_REGS -648
-
 	cfi_def_cfa_offset (648)
+
+	nop
+	.align 4
+
 __syscall_sigreturn:
 	mov	sp, a0
 	ldi	v0, __NR_sigreturn
@@ -98,8 +99,9 @@ __syscall_sigreturn:
 	.size	__syscall_sigreturn, .-__syscall_sigreturn
 	.type	__syscall_sigreturn, @function
 
-	.align 4
 	cfi_def_cfa_offset (176 + 648)
+	.align 4
+
 __syscall_rt_sigreturn:
 	mov	sp,a0
 	ldi	v0,__NR_rt_sigreturn

  reply	other threads:[~2013-11-13 22:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-04  1:11 Matt Turner
2013-11-13 22:52 ` Richard Henderson [this message]
2013-11-14  2:18   ` Matt Turner
2013-11-14  7:27     ` Uros Bizjak
2013-11-14 16:43       ` Matt Turner
2013-11-14 17:29         ` Uros Bizjak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52840226.4010801@twiddle.net \
    --to=rth@twiddle.net \
    --cc=alpha@gentoo.org \
    --cc=libc-ports@sourceware.org \
    --cc=mattst88@gmail.com \
    --cc=ubizjak@gmail.com \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).