From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8842 invoked by alias); 14 Nov 2013 18:28:50 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 8824 invoked by uid 89); 14 Nov 2013 18:28:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: USMAMAIL.TILERA.COM Received: from Unknown (HELO USMAMAIL.TILERA.COM) (12.216.194.151) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 14 Nov 2013 18:28:48 +0000 Received: from [10.7.0.95] (10.9.0.23) by USMAExch2.tad.internal.tilera.com (10.3.0.33) with Microsoft SMTP Server id 14.0.722.0; Thu, 14 Nov 2013 13:28:26 -0500 Message-ID: <52851656.1070303@tilera.com> Date: Thu, 14 Nov 2013 18:28:00 -0000 From: Chris Metcalf User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Chung-Lin Tang , "Joseph S. Myers" CC: "libc-ports@sourceware.org" , Andrew Pinski Subject: Re: struct statfs/statfs64 in linux-generic References: <52774A2F.5010505@codesourcery.com> <527BF01B.9080704@tilera.com> <527F42AF.8060204@codesourcery.com> <5283357D.2050205@codesourcery.com> <528452BE.6020904@codesourcery.com> In-Reply-To: <528452BE.6020904@codesourcery.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00016.txt.bz2 On 11/13/2013 11:34 PM, Chung-Lin Tang wrote: > On 13/11/13 8:58 PM, Joseph S. Myers wrote: >> On Wed, 13 Nov 2013, Chung-Lin Tang wrote: >> >>> (struct statfs): Use __alignof__(__u64) in alignment attribute >>> instead of 8. >>> (struct statfs64): Likewise. >> I don't like the use of __u64 here - that's a kernel type, not a glibc >> one, and glibc headers shouldn't be using it. >> > Sure, how about __U64_TYPE? This seems in line with using __SWORD_TYPE > from Looking at this, I wonder if we need the alignment attribute on the structure at all. Given that the __field64 macro fields have that alignment attribute, the structure as a whole should also automatically have it, so it seems superfluous. Does it work on nios2 if you remove the struct alignment directive? The kernel version of the structure doesn't have any forced alignment on it. -- Chris Metcalf, Tilera Corp. http://www.tilera.com