From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24879 invoked by alias); 15 Nov 2013 07:39:39 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 24866 invoked by uid 89); 15 Nov 2013 07:39:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Nov 2013 07:39:38 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1VhDzu-0003go-9d from ChungLin_Tang@mentor.com ; Thu, 14 Nov 2013 23:39:22 -0800 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 14 Nov 2013 23:39:22 -0800 Received: from air.local (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Thu, 14 Nov 2013 23:39:20 -0800 Message-ID: <5285CFA6.8020700@codesourcery.com> Date: Fri, 15 Nov 2013 07:39:00 -0000 From: Chung-Lin Tang User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Chris Metcalf , "Joseph S. Myers" CC: "libc-ports@sourceware.org" , Andrew Pinski Subject: Re: struct statfs/statfs64 in linux-generic References: <52774A2F.5010505@codesourcery.com> <527BF01B.9080704@tilera.com> <527F42AF.8060204@codesourcery.com> <5283357D.2050205@codesourcery.com> <528452BE.6020904@codesourcery.com> <52851656.1070303@tilera.com> In-Reply-To: <52851656.1070303@tilera.com> Content-Type: multipart/mixed; boundary="------------050700020707070407090802" X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00019.txt.bz2 --------------050700020707070407090802 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-length: 1489 On 13/11/15 2:28 AM, Chris Metcalf wrote: > On 11/13/2013 11:34 PM, Chung-Lin Tang wrote: >> On 13/11/13 8:58 PM, Joseph S. Myers wrote: >>> On Wed, 13 Nov 2013, Chung-Lin Tang wrote: >>> >>>> (struct statfs): Use __alignof__(__u64) in alignment attribute >>>> instead of 8. >>>> (struct statfs64): Likewise. >>> I don't like the use of __u64 here - that's a kernel type, not a glibc >>> one, and glibc headers shouldn't be using it. >>> >> Sure, how about __U64_TYPE? This seems in line with using __SWORD_TYPE >> from > > Looking at this, I wonder if we need the alignment attribute on the structure at all. Given that the __field64 macro fields have that alignment attribute, the structure as a whole should also automatically have it, so it seems superfluous. Does it work on nios2 if you remove the struct alignment directive? > > The kernel version of the structure doesn't have any forced alignment on it. > Yes, that works for nios2. Appears that struct stat/stat64 in bits/stat.h doesn't have the struct alignment attributes either. Updated patch attached. Chung-Lin 2013-11-13 Chung-Lin Tang ports/ * sysdeps/unix/sysv/linux/generic/bits/stat.h (__field64): Use __alignof__(type64) in alignment attribute instead of 8. * sysdeps/unix/sysv/linux/generic/bits/statfs.h (__field64): Use __alignof__(type64) in alignment attribute instead of 8. (struct statfs): Remove alignment attribute. (struct statfs64): Likewise. --------------050700020707070407090802 Content-Type: text/plain; charset="UTF-8"; x-mac-type=0; x-mac-creator=0; name="x.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="x.diff" Content-length: 2668 ZGlmZiAtLWdpdCBhL3BvcnRzL3N5c2RlcHMvdW5peC9zeXN2L2xpbnV4L2dl bmVyaWMvYml0cy9zdGF0LmggYi9wb3J0cy9zeXNkZXBzL3VuaXgvc3lzdi9s aW51eC9nZW5lcmljL2JpdHMvc3RhdC5oCmluZGV4IDZlNzRjZWMuLmZlYjVm MmIgMTAwNjQ0Ci0tLSBhL3BvcnRzL3N5c2RlcHMvdW5peC9zeXN2L2xpbnV4 L2dlbmVyaWMvYml0cy9zdGF0LmgKKysrIGIvcG9ydHMvc3lzZGVwcy91bml4 L3N5c3YvbGludXgvZ2VuZXJpYy9iaXRzL3N0YXQuaApAQCAtNDYsMTAgKzQ2 LDEwIEBACiAjIGRlZmluZSBfX2ZpZWxkNjQodHlwZSwgdHlwZTY0LCBuYW1l KSB0eXBlIG5hbWUKICNlbGlmIF9fQllURV9PUkRFUiA9PSBfX0xJVFRMRV9F TkRJQU4KICMgZGVmaW5lIF9fZmllbGQ2NCh0eXBlLCB0eXBlNjQsIG5hbWUp IFwKLSAgdHlwZSBuYW1lIF9fYXR0cmlidXRlX18oKF9fYWxpZ25lZF9fKDgp KSk7IGludCBfXyMjbmFtZSMjX3BhZAorICB0eXBlIG5hbWUgX19hdHRyaWJ1 dGVfXygoX19hbGlnbmVkX18gKF9fYWxpZ25vZl9fICh0eXBlNjQpKSkpOyBp bnQgX18jI25hbWUjI19wYWQKICNlbHNlCiAjIGRlZmluZSBfX2ZpZWxkNjQo dHlwZSwgdHlwZTY0LCBuYW1lKSBcCi0gIGludCBfXyMjbmFtZSMjX3BhZCBf X2F0dHJpYnV0ZV9fKChfX2FsaWduZWRfXyg4KSkpOyB0eXBlIG5hbWUKKyAg aW50IF9fIyNuYW1lIyNfcGFkIF9fYXR0cmlidXRlX18oKF9fYWxpZ25lZF9f IChfX2FsaWdub2ZfXyAodHlwZTY0KSkpKTsgdHlwZSBuYW1lCiAjZW5kaWYK IAogc3RydWN0IHN0YXQKZGlmZiAtLWdpdCBhL3BvcnRzL3N5c2RlcHMvdW5p eC9zeXN2L2xpbnV4L2dlbmVyaWMvYml0cy9zdGF0ZnMuaCBiL3BvcnRzL3N5 c2RlcHMvdW5peC9zeXN2L2xpbnV4L2dlbmVyaWMvYml0cy9zdGF0ZnMuaApp bmRleCA3MDYzYzdhLi44YWVjYjA0IDEwMDY0NAotLS0gYS9wb3J0cy9zeXNk ZXBzL3VuaXgvc3lzdi9saW51eC9nZW5lcmljL2JpdHMvc3RhdGZzLmgKKysr IGIvcG9ydHMvc3lzZGVwcy91bml4L3N5c3YvbGludXgvZ2VuZXJpYy9iaXRz L3N0YXRmcy5oCkBAIC0zOCwxMCArMzgsMTAgQEAKICMgZGVmaW5lIF9fZmll bGQ2NCh0eXBlLCB0eXBlNjQsIG5hbWUpIHR5cGUgbmFtZQogI2VsaWYgX19C WVRFX09SREVSID09IF9fTElUVExFX0VORElBTgogIyBkZWZpbmUgX19maWVs ZDY0KHR5cGUsIHR5cGU2NCwgbmFtZSkgXAotICB0eXBlIG5hbWUgX19hdHRy aWJ1dGVfXygoX19hbGlnbmVkX18oOCkpKTsgaW50IF9fIyNuYW1lIyNfcGFk CisgIHR5cGUgbmFtZSBfX2F0dHJpYnV0ZV9fKChfX2FsaWduZWRfXyAoX19h bGlnbm9mX18gKHR5cGU2NCkpKSk7IGludCBfXyMjbmFtZSMjX3BhZAogI2Vs c2UKICMgZGVmaW5lIF9fZmllbGQ2NCh0eXBlLCB0eXBlNjQsIG5hbWUpIFwK LSAgaW50IF9fIyNuYW1lIyNfcGFkIF9fYXR0cmlidXRlX18oKF9fYWxpZ25l ZF9fKDgpKSk7IHR5cGUgbmFtZQorICBpbnQgX18jI25hbWUjI19wYWQgX19h dHRyaWJ1dGVfXygoX19hbGlnbmVkX18gKF9fYWxpZ25vZl9fICh0eXBlNjQp KSkpOyB0eXBlIG5hbWUKICNlbmRpZgogCiBzdHJ1Y3Qgc3RhdGZzCkBAIC01 OCw3ICs1OCw3IEBAIHN0cnVjdCBzdGF0ZnMKICAgICBfX1NXT1JEX1RZUEUg Zl9mcnNpemU7CiAgICAgX19TV09SRF9UWVBFIGZfZmxhZ3M7CiAgICAgX19T V09SRF9UWVBFIGZfc3BhcmVbNF07Ci0gIH0gX19hdHRyaWJ1dGVfXygoX19h bGlnbmVkX18oOCkpKTsKKyAgfTsKIAogI3VuZGVmIF9fZmllbGQ2NAogCkBA IC03Nyw3ICs3Nyw3IEBAIHN0cnVjdCBzdGF0ZnM2NAogICAgIF9fU1dPUkRf VFlQRSBmX2Zyc2l6ZTsKICAgICBfX1NXT1JEX1RZUEUgZl9mbGFnczsKICAg ICBfX1NXT1JEX1RZUEUgZl9zcGFyZVs0XTsKLSAgfSBfX2F0dHJpYnV0ZV9f KChfX2FsaWduZWRfXyg4KSkpOworICB9OwogI2VuZGlmCiAKIC8qIFRlbGwg Y29kZSB3ZSBoYXZlIHRoZXNlIG1lbWJlcnMuICAqLwo= --------------050700020707070407090802--