From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16356 invoked by alias); 18 Nov 2013 18:21:08 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 16168 invoked by uid 89); 18 Nov 2013 18:21:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: USMAMAIL.TILERA.COM Received: from Unknown (HELO USMAMAIL.TILERA.COM) (12.216.194.151) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 18 Nov 2013 18:21:05 +0000 Received: from [10.7.0.95] (10.9.0.23) by USMAExch2.tad.internal.tilera.com (10.3.0.33) with Microsoft SMTP Server id 14.0.722.0; Mon, 18 Nov 2013 13:20:36 -0500 Message-ID: <528A5A89.10507@tilera.com> Date: Mon, 18 Nov 2013 23:39:00 -0000 From: Chris Metcalf User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Chung-Lin Tang , "Joseph S. Myers" CC: "libc-ports@sourceware.org" , Andrew Pinski , Marcus Shawcroft Subject: Re: struct statfs/statfs64 in linux-generic References: <52774A2F.5010505@codesourcery.com> <527BF01B.9080704@tilera.com> <527F42AF.8060204@codesourcery.com> <5283357D.2050205@codesourcery.com> <528452BE.6020904@codesourcery.com> <52851656.1070303@tilera.com> <5285CFA6.8020700@codesourcery.com> In-Reply-To: <5285CFA6.8020700@codesourcery.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00033.txt.bz2 On 11/15/2013 2:39 AM, Chung-Lin Tang wrote: > Yes, that works for nios2. Appears that struct stat/stat64 in > bits/stat.h doesn't have the struct alignment attributes either. > Updated patch attached. > > Chung-Lin > > 2013-11-13 Chung-Lin Tang > > ports/ > * sysdeps/unix/sysv/linux/generic/bits/stat.h (__field64): Use > __alignof__(type64) in alignment attribute instead of 8. > * sysdeps/unix/sysv/linux/generic/bits/statfs.h (__field64): Use > __alignof__(type64) in alignment attribute instead of 8. > (struct statfs): Remove alignment attribute. > (struct statfs64): Likewise. The patch works fine for tilegx, so I think it should be OK to commit. Marcus, did you want to verify that it works OK for AArch64 first? My guess it that it should be OK for you. Chung-Lin Tang, do you have commit access, or would you like me to commit the change for you? -- Chris Metcalf, Tilera Corp. http://www.tilera.com