From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11812 invoked by alias); 19 Nov 2013 03:28:52 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 11800 invoked by uid 89); 19 Nov 2013 03:28:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.1 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Nov 2013 03:28:48 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1VibzN-0001XH-1g from ChungLin_Tang@mentor.com ; Mon, 18 Nov 2013 19:28:33 -0800 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 18 Nov 2013 19:28:32 -0800 Received: from air.local (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Mon, 18 Nov 2013 19:28:32 -0800 Message-ID: <528ADADE.4050507@codesourcery.com> Date: Tue, 19 Nov 2013 13:50:00 -0000 From: Chung-Lin Tang User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Chris Metcalf , "Joseph S. Myers" CC: "libc-ports@sourceware.org" , Andrew Pinski , Marcus Shawcroft Subject: Re: struct statfs/statfs64 in linux-generic References: <52774A2F.5010505@codesourcery.com> <527BF01B.9080704@tilera.com> <527F42AF.8060204@codesourcery.com> <5283357D.2050205@codesourcery.com> <528452BE.6020904@codesourcery.com> <52851656.1070303@tilera.com> <5285CFA6.8020700@codesourcery.com> <528A5A89.10507@tilera.com> In-Reply-To: <528A5A89.10507@tilera.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00037.txt.bz2 On 13/11/19 2:20 AM, Chris Metcalf wrote: > On 11/15/2013 2:39 AM, Chung-Lin Tang wrote: >> Yes, that works for nios2. Appears that struct stat/stat64 in >> bits/stat.h doesn't have the struct alignment attributes either. >> Updated patch attached. >> >> Chung-Lin >> >> 2013-11-13 Chung-Lin Tang >> >> ports/ >> * sysdeps/unix/sysv/linux/generic/bits/stat.h (__field64): Use >> __alignof__(type64) in alignment attribute instead of 8. >> * sysdeps/unix/sysv/linux/generic/bits/statfs.h (__field64): Use >> __alignof__(type64) in alignment attribute instead of 8. >> (struct statfs): Remove alignment attribute. >> (struct statfs64): Likewise. > > The patch works fine for tilegx, so I think it should be OK to commit. > > Marcus, did you want to verify that it works OK for AArch64 first? > My guess it that it should be OK for you. > > Chung-Lin Tang, do you have commit access, or would you like me to > commit the change for you? No, I don't think I have commit access for glibc (it's separate from binutils/gdb I think?) Please commit for me. Thanks, Chung-Lin