From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19416 invoked by alias); 26 Nov 2013 15:19:16 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 19406 invoked by uid 89); 26 Nov 2013 15:19:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Nov 2013 15:19:14 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAQFJ5MW009141 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 26 Nov 2013 10:19:05 -0500 Received: from [10.3.113.12] ([10.3.113.12]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rAQFJ4dq028845; Tue, 26 Nov 2013 10:19:05 -0500 Message-ID: <5294BBE8.1060604@redhat.com> Date: Tue, 26 Nov 2013 15:24:00 -0000 From: "Carlos O'Donell" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Will Newton , libc-ports@sourceware.org CC: Patch Tracking Subject: Re: [PATCH] aarch64: Enable ifunc support. References: <5294628E.30507@linaro.org> <5294BB3E.70406@redhat.com> In-Reply-To: <5294BB3E.70406@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00059.txt.bz2 On 11/26/2013 10:16 AM, Carlos O'Donell wrote: > On 11/26/2013 03:57 AM, Will Newton wrote: >> >> Add support for handling the R_AARCH64_IRELATIVE relocation and >> STT_GNU_IFUNC symbols to the aarch64 port. >> >> ports/ChangeLog.aarch64: >> >> 2013-11-25 Will Newton >> >> * sysdeps/aarch64/dl-irel.h: Include ldsodefs.h. >> (ELF_MACHINE_IRELA): Define. (elf_ifunc_invoke): Pass >> hwcap to ifunc resolver function. (elf_irela): New function. >> * sysdeps/aarch64/dl-machine.h: Include dl-irel.h. >> (elf_machine_rela) Handle STT_GNU_IFUNC symbols and >> R_AARCH64_IRELATIVE relocations. (elf_machine_lazy_rel): >> Handle R_AARCH64_IRELATIVE relocations. > > You don't appear to fix elf_ifunc_invoke to pass dl_hwcap to the > resolver which will need this to detect the different kinds of > hardware? Sorry, I'm wrong, I missed that line in your patch. You do pass dl_hwcap. c.