From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8485 invoked by alias); 26 Nov 2013 16:25:59 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 8474 invoked by uid 89); 26 Nov 2013 16:25:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_20,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Nov 2013 16:25:57 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAQGPlg0011111 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 26 Nov 2013 11:25:48 -0500 Received: from [10.3.113.12] ([10.3.113.12]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rAQGPkka029877; Tue, 26 Nov 2013 11:25:47 -0500 Message-ID: <5294CB8A.9080206@redhat.com> Date: Tue, 26 Nov 2013 16:37:00 -0000 From: "Carlos O'Donell" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Will Newton CC: "libc-ports@sourceware.org" , Patch Tracking Subject: Re: [PATCH] aarch64: Enable ifunc support. References: <5294628E.30507@linaro.org> <5294BD18.40507@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00063.txt.bz2 On 11/26/2013 10:39 AM, Will Newton wrote: > On 26 November 2013 15:24, Carlos O'Donell wrote: >> On 11/26/2013 03:57 AM, Will Newton wrote: >>> >>> Add support for handling the R_AARCH64_IRELATIVE relocation and >>> STT_GNU_IFUNC symbols to the aarch64 port. >> >> How did you test this? > > Running the glibc testsuite - which is actually a pretty good test for > the ifunc code. There's no functionality in the aarch64 port yet that > actually uses this yet so I couldn't test that. The only screw up that > the testsuite does not find is failing to pass hwcap correctly to the > resover, but I pretty intensively stared at that code and seen as > everything goes through elf_ifunc_invoke I am happy that it should > work in practice. Perfect, then I'm happy with the patch. If Marcus is happy then I think you get to check this in. Cheers, Carlos.