public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Venkataramanan Kumar <venkataramanan.kumar@linaro.org>
Cc: libc-ports@sourceware.org,
	 Marcus Shawcroft <marcus.shawcroft@gmail.com>,
	Marcus Shawcroft <marcus.shawcroft@arm.com>,
	 Carlos O'Donell <carlos@redhat.com>,
	Patch Tracking <patch@linaro.org>
Subject: Re: [PATCH] [AARCH64]: Pointer mangling support for Aarch64
Date: Fri, 27 Dec 2013 15:09:00 -0000	[thread overview]
Message-ID: <52BD983C.5050006@twiddle.net> (raw)
In-Reply-To: <CAJK_mQ1GeEf4MjMBcijmwKef33kZEmoHkJv8xgqX5=k4_t9YPg@mail.gmail.com>

On 12/26/2013 11:48 PM, Venkataramanan Kumar wrote:
> +/* Load or store to/from a pc-relative EXPR into/from R, using T.  */
> +#define LDST_PCREL(OP, R, T, EXPR)\
> +	adrp	T, EXPR;	  \
> +	add	T, T, #:lo12:EXPR;\
> +	OP	R, [T];

Is T supposed to be live after the macro?  Otherwise the whole point of the
12-bit offset is that it can be used inside the memory operation offset.

As you in fact do with the LDST_GLOBAL macro just below.


r~

  reply	other threads:[~2013-12-27 15:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-26 12:25 Venkataramanan Kumar
2013-12-26 19:33 ` Richard Henderson
2013-12-27  7:48   ` Venkataramanan Kumar
2013-12-27 15:09     ` Richard Henderson [this message]
2013-12-30  5:00       ` Venkataramanan Kumar
2013-12-30 14:45         ` Richard Henderson
2013-12-30 15:36           ` Venkataramanan Kumar
2013-12-30 22:20         ` Marcus Shawcroft
2013-12-31  5:15           ` Venkataramanan Kumar
2014-01-01 17:42             ` Marcus Shawcroft
2014-01-06 18:11 ` Tom Tromey
2014-01-07 11:05   ` Venkataramanan Kumar
2014-01-07 12:17     ` Marcus Shawcroft
2014-01-07 18:10       ` Tom Tromey
2014-01-10  9:54         ` Will Newton
2014-01-20  9:01         ` Will Newton
2014-01-20 16:45           ` Tom Tromey
2014-01-20 17:02             ` Will Newton
2014-01-08 10:32       ` Venkataramanan Kumar
2014-01-10 10:40         ` Marcus Shawcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52BD983C.5050006@twiddle.net \
    --to=rth@twiddle.net \
    --cc=carlos@redhat.com \
    --cc=libc-ports@sourceware.org \
    --cc=marcus.shawcroft@arm.com \
    --cc=marcus.shawcroft@gmail.com \
    --cc=patch@linaro.org \
    --cc=venkataramanan.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).