From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17584 invoked by alias); 27 Dec 2013 15:09:59 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 17547 invoked by uid 89); 27 Dec 2013 15:09:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f45.google.com Received: from mail-pa0-f45.google.com (HELO mail-pa0-f45.google.com) (209.85.220.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 27 Dec 2013 15:09:53 +0000 Received: by mail-pa0-f45.google.com with SMTP id fb1so9423645pad.32 for ; Fri, 27 Dec 2013 07:09:52 -0800 (PST) X-Received: by 10.66.67.3 with SMTP id j3mr34383373pat.142.1388156991903; Fri, 27 Dec 2013 07:09:51 -0800 (PST) Received: from anchor.twiddle.net (50-194-63-110-static.hfc.comcastbusiness.net. [50.194.63.110]) by mx.google.com with ESMTPSA id hz10sm62852515pbc.36.2013.12.27.07.09.49 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 27 Dec 2013 07:09:50 -0800 (PST) Message-ID: <52BD983C.5050006@twiddle.net> Date: Fri, 27 Dec 2013 15:09:00 -0000 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Venkataramanan Kumar CC: libc-ports@sourceware.org, Marcus Shawcroft , Marcus Shawcroft , Carlos O'Donell , Patch Tracking Subject: Re: [PATCH] [AARCH64]: Pointer mangling support for Aarch64 References: <52BC8489.9040307@twiddle.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00033.txt.bz2 On 12/26/2013 11:48 PM, Venkataramanan Kumar wrote: > +/* Load or store to/from a pc-relative EXPR into/from R, using T. */ > +#define LDST_PCREL(OP, R, T, EXPR)\ > + adrp T, EXPR; \ > + add T, T, #:lo12:EXPR;\ > + OP R, [T]; Is T supposed to be live after the macro? Otherwise the whole point of the 12-bit offset is that it can be used inside the memory operation offset. As you in fact do with the LDST_GLOBAL macro just below. r~