From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1560 invoked by alias); 29 Apr 2014 09:14:48 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 1549 invoked by uid 89); 29 Apr 2014 09:14:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 Apr 2014 09:14:47 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s3T9Ei2Z017592 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 29 Apr 2014 05:14:45 -0400 Received: from [10.3.113.56] (ovpn-113-56.phx2.redhat.com [10.3.113.56]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s3T9EikG004112; Tue, 29 Apr 2014 05:14:44 -0400 Message-ID: <535F6D84.2030309@redhat.com> Date: Tue, 29 Apr 2014 09:14:00 -0000 From: "Carlos O'Donell" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Bernie Ogden , libc-ports@sourceware.org Subject: Re: [PATCH] Remove hppa lowlevellock.c References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00007.txt.bz2 On 04/28/2014 11:51 AM, Bernie Ogden wrote: > lowlevellock.c for hppa differs from the generic lowlevellock.c only in > insignificant ways, so can be removed. I don't have any hppa targets > to work with, so have not been able to test this patch. > > The notable differences between the hppa and generic implementations are: > > 1) Some functions in hppa's lowlevellock.c set futex to 2 if it was 1. > The generic version always sets the futex to 2. As futex can only be > 0, 1 or 2 on entry into these functions, the behaviour is equivalent. > (If the futex manages to be 0 on entry then we've just lost an > unlikely fast path out.) > 2) hppa places most of the functions in this file in both libc and > libpthread. The generic implementation places only > __lll_lock_wait_private in libc. As these are internal functions I > think that, if this does cause a problem, it would show up at build > time - but I'm new to glibc so prepared to be corrected (and have not > been able to build). > > I would be grateful if the maintainer could test/comment. > > Regards, > > Bernie > > ports/ChangeLog.hppa > 2014-04-24 Bernard Ogden > > [BZ #15119] > * ports/sysdeps/unix/sysv/linux/hppa/nptl/lowlevellock.c: Remove file. Looks good to me. hppa's futex implementation should match the generic defaults at all times. Cheers, Carlos.