From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-ports-return-4698-listarch-libc-ports=sources.redhat.com@sourceware.org>
Received: (qmail 1459 invoked by alias); 6 Jan 2014 18:11:00 -0000
Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-ports.sourceware.org>
List-Subscribe: <mailto:libc-ports-subscribe@sourceware.org>
List-Post: <mailto:libc-ports@sourceware.org>
List-Help: <mailto:libc-ports-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: libc-ports-owner@sourceware.org
Received: (qmail 1449 invoked by uid 89); 6 Jan 2014 18:10:59 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Jan 2014 18:10:59 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s06IApAm026702	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 6 Jan 2014 13:10:51 -0500
Received: from barimba (ovpn-113-85.phx2.redhat.com [10.3.113.85])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s06IAn54010062	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 6 Jan 2014 13:10:50 -0500
From: Tom Tromey <tromey@redhat.com>
To: Venkataramanan Kumar <venkataramanan.kumar@linaro.org>
Cc: libc-ports@sourceware.org, Marcus Shawcroft <marcus.shawcroft@gmail.com>,        Marcus Shawcroft <marcus.shawcroft@arm.com>,        "Carlos O'Donell" <carlos@redhat.com>,        Patch Tracking <patch@linaro.org>
Subject: Re: [PATCH] [AARCH64]: Pointer mangling support for Aarch64
References: <CAJK_mQ0EoE+_JQvSL+5=C_+Q6JgsV8hvXipy8OgR8+GYyYgt3A@mail.gmail.com>
Date: Mon, 06 Jan 2014 18:11:00 -0000
In-Reply-To: <CAJK_mQ0EoE+_JQvSL+5=C_+Q6JgsV8hvXipy8OgR8+GYyYgt3A@mail.gmail.com>	(Venkataramanan Kumar's message of "Thu, 26 Dec 2013 17:55:08 +0530")
Message-ID: <87iotxm15i.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2014-01/txt/msg00016.txt.bz2

>>>>> ">" == Venkataramanan Kumar <venkataramanan.kumar@linaro.org> writes:

>> This patch adds pointer mangling support for Aarch64.

IIRC the Aarch64 longjmp code doesn't have the sdt.h probes in place.
If you add pointer mangling without also adding the sdt.h probes, then
gdb's longjmp support will break.  You should be able to see this easily
in the gdb test suite.

Adding the probes is quite easy to do, so I encourage you to add that
to the patch.

thanks,
Tom