From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1548 invoked by alias); 20 Feb 2013 17:56:19 -0000 Received: (qmail 1515 invoked by uid 22791); 20 Feb 2013 17:56:18 -0000 X-SWARE-Spam-Status: No, hits=-7.8 required=5.0 tests=AWL,BAYES_00,KHOP_PGP_SIGNED,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Feb 2013 17:56:12 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1U8Dtr-0005wx-SJ from Thomas_Schwinge@mentor.com ; Wed, 20 Feb 2013 09:56:11 -0800 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 20 Feb 2013 09:56:11 -0800 Received: from feldtkeller.schwinge.homeip.net (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Wed, 20 Feb 2013 17:56:09 +0000 From: Thomas Schwinge To: Carlos O'Donell CC: Carlos O'Donell , Richard Henderson , , , Subject: Re: Usage of __attribute__used__ in (system) headers? In-Reply-To: <5124F8F2.8030708@redhat.com> References: <87r4khnbqm.fsf@kepler.schwinge.homeip.net> <51227F2E.5060103@twiddle.net> <87vc9nc6ma.fsf@schwinge.name> <5124F8F2.8030708@redhat.com> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/23.4.1 (x86_64-pc-linux-gnu) Date: Wed, 20 Feb 2013 17:56:00 -0000 Message-ID: <87mwuydg3w.fsf@schwinge.name> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00053.txt.bz2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 1533 Hi! On Wed, 20 Feb 2013 11:25:22 -0500, Carlos O'Donell wro= te: > > static union { unsigned char __c[4]; float __d; } __nan_union > > - __attribute_used__ =3D { __nan_bytes }; > > + __attribute__ ((unused)) =3D { __nan_bytes }; > Please fix this to use __unused__. >=20 > We should not use attributes that are in the user's namespace. Pushed as commit 50022a93fcc36a0130b9f882709ff69f4b91c0cc: * sysdeps/ieee754/bits/nan.h [!__GNUC__] (__nan_union): Change __attribute__ ((unused)) to __attribute__ ((__unused__)). ports/ * sysdeps/mips/bits/nan.h [!__GNUC__] (__nan_union): Change __attribute__ ((unused)) to __attribute__ ((__unused__)). diff --git ports/sysdeps/mips/bits/nan.h ports/sysdeps/mips/bits/nan.h index 8f4666d..7aa157b 100644 --- ports/sysdeps/mips/bits/nan.h +++ ports/sysdeps/mips/bits/nan.h @@ -50,7 +50,7 @@ # endif =20 static union { unsigned char __c[4]; float __d; } __nan_union - __attribute__ ((unused)) =3D { __nan_bytes }; + __attribute__ ((__unused__)) =3D { __nan_bytes }; # define NAN (__nan_union.__d) =20 #endif /* GCC. */ diff --git sysdeps/ieee754/bits/nan.h sysdeps/ieee754/bits/nan.h index a1e6a51..935271a 100644 --- sysdeps/ieee754/bits/nan.h +++ sysdeps/ieee754/bits/nan.h @@ -46,7 +46,7 @@ # endif =20 static union { unsigned char __c[4]; float __d; } __nan_union - __attribute__ ((unused)) =3D { __nan_bytes }; + __attribute__ ((__unused__)) =3D { __nan_bytes }; # define NAN (__nan_union.__d) =20 #endif /* GCC. */ Gr=C3=BC=C3=9Fe, Thomas --=-=-= Content-Type: application/pgp-signature Content-length: 489 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQEcBAEBAgAGBQJRJQ4zAAoJENuKOtuXzphJpwIIAKHy2vCbYDPN2SUeoia67Vqk QNyAoJarAf+GtqXEoB9N5gxBs1NRTNksYU9ZyZtkaOOTlsa80TBw/9s3uYyKUJdL oD+rCh1pC/YeiKnW4tbj1ew+keIkHEB0WcXpaengjOWMq7mSEoy0kQj9RYMJxZTb NXyKaExJQ9phVExTN5rBJA3jP4GsHylpHiq0TQSzAaqyv+y3P9VBm17GepUKy8dM TC5cnSh96ZqVfTP0TYwDixqnmRnq7lQYWsItu2O21xP3lvgLYp3j9tpc3wpYA1jd zEjopkx/JKd7RWKRmfHHf+KUWKkUaL6Jf89x6/TzUpMXXWRdD9hws91a409WnKM= =scYC -----END PGP SIGNATURE----- --=-=-=--