From: "Steve Ellcey " <sellcey@mips.com>
To: <libc-ports@sourceware.org>
Subject: Patch for MIPS PREF/PREFX macro definitions
Date: Tue, 31 Jul 2012 22:59:00 -0000 [thread overview]
Message-ID: <8ac30d67-bdbe-4e7b-8b32-5a951f425bf5@EXCHHUB01.MIPS.com> (raw)
I was wondering if someone could check in this obvious fix for MIPS.
The code is supposed to define the PREF and PREFX macro calls as nothing
when on a machine that doesn't support prefetching but the empty
definitions don't include the argument lists and that causes the
arguments to show up in the code which is wrong.
Steve Ellcey
sellcey@mips.com
Here is the patch:
2012-07-31 Steve Ellcey <sellcey@mips.com>
* sysdeps/mips/sys/asm.h: Fix PREF and PREFX definitions.
diff --git a/ports/sysdeps/mips/sys/asm.h b/ports/sysdeps/mips/sys/asm.h
index 347d738..0f5edf9 100644
--- a/ports/sysdeps/mips/sys/asm.h
+++ b/ports/sysdeps/mips/sys/asm.h
@@ -233,8 +233,8 @@ symbol = value
# define PREFX(hint,addr) \
prefx hint,addr
#else
-# define PREF
-# define PREFX
+# define PREF(hint,addr)
+# define PREFX(hint,addr)
#endif
/*
next reply other threads:[~2012-07-31 22:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 22:59 Steve Ellcey [this message]
2012-08-01 15:13 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ac30d67-bdbe-4e7b-8b32-5a951f425bf5@EXCHHUB01.MIPS.com \
--to=sellcey@mips.com \
--cc=libc-ports@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).