From: Bernard Ogden <bernie.ogden@linaro.org>
To: Carlos O'Donell <carlos@redhat.com>
Cc: libc-ports@sourceware.org
Subject: Re: [PATCH] Remove hppa lowlevellock.c
Date: Mon, 09 Jun 2014 20:29:00 -0000 [thread overview]
Message-ID: <92BD7482-D72D-41A5-AEA3-B4AF3F191EA4@linaro.org> (raw)
In-Reply-To: <535F6D84.2030309@redhat.com>
I've completed failed to ping this - sorry.
Would you mind committing?
Thanks,
Bernie
On 29 Apr 2014, at 10:14, Carlos O'Donell <carlos@redhat.com> wrote:
> On 04/28/2014 11:51 AM, Bernie Ogden wrote:
>> lowlevellock.c for hppa differs from the generic lowlevellock.c only in
>> insignificant ways, so can be removed. I don't have any hppa targets
>> to work with, so have not been able to test this patch.
>>
>> The notable differences between the hppa and generic implementations are:
>>
>> 1) Some functions in hppa's lowlevellock.c set futex to 2 if it was 1.
>> The generic version always sets the futex to 2. As futex can only be
>> 0, 1 or 2 on entry into these functions, the behaviour is equivalent.
>> (If the futex manages to be 0 on entry then we've just lost an
>> unlikely fast path out.)
>> 2) hppa places most of the functions in this file in both libc and
>> libpthread. The generic implementation places only
>> __lll_lock_wait_private in libc. As these are internal functions I
>> think that, if this does cause a problem, it would show up at build
>> time - but I'm new to glibc so prepared to be corrected (and have not
>> been able to build).
>>
>> I would be grateful if the maintainer could test/comment.
>>
>> Regards,
>>
>> Bernie
>>
>> ports/ChangeLog.hppa
>> 2014-04-24 Bernard Ogden <bernie.ogden@linaro.org>
>>
>> [BZ #15119]
>> * ports/sysdeps/unix/sysv/linux/hppa/nptl/lowlevellock.c: Remove file.
>
> Looks good to me.
>
> hppa's futex implementation should match the generic defaults at all times.
>
> Cheers,
> Carlos.
>
next prev parent reply other threads:[~2014-06-09 20:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 15:51 Bernie Ogden
2014-04-28 17:02 ` Carlos O'Donell
2014-04-29 9:14 ` Carlos O'Donell
2014-06-09 20:29 ` Bernard Ogden [this message]
2014-06-10 3:25 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92BD7482-D72D-41A5-AEA3-B4AF3F191EA4@linaro.org \
--to=bernie.ogden@linaro.org \
--cc=carlos@redhat.com \
--cc=libc-ports@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).