From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24406 invoked by alias); 9 Jun 2014 20:29:30 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 24299 invoked by uid 89); 9 Jun 2014 20:29:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wg0-f43.google.com Received: from mail-wg0-f43.google.com (HELO mail-wg0-f43.google.com) (74.125.82.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 09 Jun 2014 20:29:27 +0000 Received: by mail-wg0-f43.google.com with SMTP id b13so1647787wgh.14 for ; Mon, 09 Jun 2014 13:29:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=0bOr2gAdrYOLrTjQDXGsAxWyirJWPN/WQZarxftrt6A=; b=GQGOUHxL5GtiS96BY5f0oemMA4iuOjWxQrX0Ga/jEMrbAaPQ/zfSY6NThI31HoilVm aC7b14ZdMXOYLTd0WGk5RXheTwHDgpnPeqVBZEWL75ZkG2LkkrU45IZqBZ0ClkQuCiHA CqrB4aGQ93fxTCqxG/Woub5R6hP/N3mm5LCdfBqavIMdsiRXiS5HCYLgzLf1kLxTKFp0 FZNqPQtq3MvuXGTy9t5Z5rAoZMt5mtjdTcW9KYv83Xs+x/mf21/69GV3j+CZPuYu72Ad WVR2+mWby2VU0BzrY+9Y/MpQn/mwAQLVPxiOHMtq7Q36eh8kmDlQh8dyDecS2EMI8bGf VXXg== X-Gm-Message-State: ALoCoQk8gSIyL5/c3Bl1/9vgufcbb7D/1AVYUBeDVBKThkLHeHsGXZTPBlEbvofptJXTnimUnqOW X-Received: by 10.180.105.72 with SMTP id gk8mr31642743wib.32.1402345764317; Mon, 09 Jun 2014 13:29:24 -0700 (PDT) Received: from e104783-mac.home (host86-129-255-105.range86-129.btcentralplus.com. [86.129.255.105]) by mx.google.com with ESMTPSA id f2sm16592798wiz.11.2014.06.09.13.29.22 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 09 Jun 2014 13:29:23 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\)) Subject: Re: [PATCH] Remove hppa lowlevellock.c From: Bernard Ogden In-Reply-To: <535F6D84.2030309@redhat.com> Date: Mon, 09 Jun 2014 20:29:00 -0000 Cc: libc-ports@sourceware.org Content-Transfer-Encoding: 7bit Message-Id: <92BD7482-D72D-41A5-AEA3-B4AF3F191EA4@linaro.org> References: <535F6D84.2030309@redhat.com> To: Carlos O'Donell X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00000.txt.bz2 I've completed failed to ping this - sorry. Would you mind committing? Thanks, Bernie On 29 Apr 2014, at 10:14, Carlos O'Donell wrote: > On 04/28/2014 11:51 AM, Bernie Ogden wrote: >> lowlevellock.c for hppa differs from the generic lowlevellock.c only in >> insignificant ways, so can be removed. I don't have any hppa targets >> to work with, so have not been able to test this patch. >> >> The notable differences between the hppa and generic implementations are: >> >> 1) Some functions in hppa's lowlevellock.c set futex to 2 if it was 1. >> The generic version always sets the futex to 2. As futex can only be >> 0, 1 or 2 on entry into these functions, the behaviour is equivalent. >> (If the futex manages to be 0 on entry then we've just lost an >> unlikely fast path out.) >> 2) hppa places most of the functions in this file in both libc and >> libpthread. The generic implementation places only >> __lll_lock_wait_private in libc. As these are internal functions I >> think that, if this does cause a problem, it would show up at build >> time - but I'm new to glibc so prepared to be corrected (and have not >> been able to build). >> >> I would be grateful if the maintainer could test/comment. >> >> Regards, >> >> Bernie >> >> ports/ChangeLog.hppa >> 2014-04-24 Bernard Ogden >> >> [BZ #15119] >> * ports/sysdeps/unix/sysv/linux/hppa/nptl/lowlevellock.c: Remove file. > > Looks good to me. > > hppa's futex implementation should match the generic defaults at all times. > > Cheers, > Carlos. >