From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24690 invoked by alias); 23 Nov 2010 20:32:32 -0000 Received: (qmail 24682 invoked by uid 22791); 23 Nov 2010 20:32:31 -0000 X-SWARE-Spam-Status: No, hits=-0.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from mail-pz0-f41.google.com (HELO mail-pz0-f41.google.com) (209.85.210.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Nov 2010 20:32:17 +0000 Received: by pzk27 with SMTP id 27so635815pzk.0 for ; Tue, 23 Nov 2010 12:32:16 -0800 (PST) Received: by 10.223.97.75 with SMTP id k11mr5897584fan.85.1290544335325; Tue, 23 Nov 2010 12:32:15 -0800 (PST) MIME-Version: 1.0 Received: by 10.204.75.197 with HTTP; Tue, 23 Nov 2010 12:24:25 -0800 (PST) From: Matt Turner Date: Tue, 23 Nov 2010 20:32:00 -0000 Message-ID: Subject: MIPS: getpagesize, PAGE_SHIFT, and PAGE_SIZE To: libc-ports@sourceware.org Cc: "Maciej W. Rozycki" , andrew.pinski@caviumnetworks.com Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00016.txt.bz2 MIPS' getpagesize.c includes the ia64 implementation. [1] The ia64 implementation is the generic Linux implementation if __ASSUME_AT_PAGESIZE is defined, and __ASSUME_AT_PAGESIZE looks to me to be defined for all platforms and kernels post-2.4.0-pre-something in kernel-features.h. Can someone explain what having __ASSUME_AT_PAGESIZE defined actually means? Is it correct that it's defined on MIPS? If so, can't we just #include the generic Linux implementation instead of ia64, or better yet, just delete MIPS' getpagesize.c? Also, PAGE_SHIFT (and by extension PAGE_SIZE) are defined as constants on MIPS. This is clearly wrong, as MIPS supports multiple pagesizes. What can we do about this? Thanks, Matt [1] http://sourceware.org/bugzilla/show_bug.cgi?id=1047