public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: pinskia@gmail.com
To: Andrew Pinski <andrew.pinski@caviumnetworks.com>
Cc: "libc-ports@sourceware.org" <libc-ports@sourceware.org>
Subject: Re: [AARCH64] Fix syscall setting of errno on bigendian
Date: Thu, 26 Sep 2013 17:56:00 -0000	[thread overview]
Message-ID: <B7D23E93-A1B8-4797-B824-491A76F38DC0@gmail.com> (raw)
In-Reply-To: <CA+=Sn1=P-o0ZjzPQboW6tx8u4MY-ZLwFsZKNCo8n3KCchdy2uw@mail.gmail.com>

Ping. 

This is an obvious patch but I don't have write access.

Thanks,
Andrew Pinski 

> On Sep 11, 2013, at 2:19 PM, Andrew Pinski <andrew.pinski@caviumnetworks.com> wrote:
> 
> Hi,
>  When we (Cavium) has been testing aarch64 on bigendian, we noticed
> that errno sometimes was not being set correctly.  The problem is that
> the store to errno was being a 64bit rather than the correct 32bit so
> the value that was being loaded later on from errno was just 0.
> 
> OK?  Build and tested on aarch64-linux-gnu and aarch64_be-linux-gnu
> without any regressions.
> 
> Thanks,ports/sysdeps/unix/sysv/linux/aarch64/sysdep.h
> Andrew Pinski
> 
> ChangeLog:
> * sysdeps/unix/sysv/linux/aarch64/sysdep.h (SYSCALL_ERROR_HANDLER):
> Fix store to errno to use 32bits.
> 
> PS I don't have git write access.
> <fixbigendian-aarch64errno.diff.txt>

  reply	other threads:[~2013-09-26 17:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-11 21:19 Andrew Pinski
2013-09-26 17:56 ` pinskia [this message]
2013-09-30 10:00 ` Marcus Shawcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B7D23E93-A1B8-4797-B824-491A76F38DC0@gmail.com \
    --to=pinskia@gmail.com \
    --cc=andrew.pinski@caviumnetworks.com \
    --cc=libc-ports@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).