From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22246 invoked by alias); 26 Sep 2013 17:56:54 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 22233 invoked by uid 89); 26 Sep 2013 17:56:54 -0000 Received: from mail-pd0-f175.google.com (HELO mail-pd0-f175.google.com) (209.85.192.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 26 Sep 2013 17:56:54 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=2.6 required=5.0 tests=ALL_TRUSTED,BAYES_00,FREEMAIL_FROM,SPAM_SUBJECT autolearn=no version=3.3.2 X-HELO: mail-pd0-f175.google.com Received: by mail-pd0-f175.google.com with SMTP id q10so1476444pdj.20 for ; Thu, 26 Sep 2013 10:56:12 -0700 (PDT) X-Received: by 10.68.234.73 with SMTP id uc9mr2588252pbc.142.1380218172338; Thu, 26 Sep 2013 10:56:12 -0700 (PDT) Received: from [10.0.0.114] ([75.94.132.18]) by mx.google.com with ESMTPSA id sy10sm6668292pac.15.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 26 Sep 2013 10:56:11 -0700 (PDT) References: Mime-Version: 1.0 (1.0) In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Message-Id: Cc: "libc-ports@sourceware.org" From: pinskia@gmail.com Subject: Re: [AARCH64] Fix syscall setting of errno on bigendian Date: Thu, 26 Sep 2013 17:56:00 -0000 To: Andrew Pinski X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00146.txt.bz2 Ping.=20 This is an obvious patch but I don't have write access. Thanks, Andrew Pinski=20 > On Sep 11, 2013, at 2:19 PM, Andrew Pinski wrote: >=20 > Hi, > When we (Cavium) has been testing aarch64 on bigendian, we noticed > that errno sometimes was not being set correctly. The problem is that > the store to errno was being a 64bit rather than the correct 32bit so > the value that was being loaded later on from errno was just 0. >=20 > OK? Build and tested on aarch64-linux-gnu and aarch64_be-linux-gnu > without any regressions. >=20 > Thanks,ports/sysdeps/unix/sysv/linux/aarch64/sysdep.h > Andrew Pinski >=20 > ChangeLog: > * sysdeps/unix/sysv/linux/aarch64/sysdep.h (SYSCALL_ERROR_HANDLER): > Fix store to errno to use 32bits. >=20 > PS I don't have git write access. >