public inbox for
 help / color / mirror / Atom feed
From: Andrew Pinski <>
To: Marcus Shawcroft <>
Cc: libc-ports <>
Subject: Re: [PATCH, COMMITTED] BZ #15128 [AArch64] Save and restore q0-q7 on entry to dynamic linker.
Date: Mon, 06 Jan 2014 22:04:00 -0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Dec 18, 2013 at 4:05 AM, Marcus Shawcroft
<> wrote:
> This patch ensures that all argument passing registers are saved and
> restored on entry to the dynamic linker and resolves BZ #15128.
> Regression tested.  Committed to trunk.  Back port to 2.18 branch will follow.

There is a bug in this patch:
- stp x8, x9, [sp, #-80]!
+ stp x8, x9, [sp, #-(80+8*16)]!
  cfi_adjust_cfa_offset (80)

You forgot to update the cfi_adjust_cfa_offset to be 80+8*16.

Andrew Pinski

> Cheers
> /Marcus

  reply	other threads:[~2014-01-06 22:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-18 12:05 Marcus Shawcroft
2014-01-06 22:04 ` Andrew Pinski [this message]
2014-01-07 10:19   ` Marcus Shawcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).