From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-ports-return-4699-listarch-libc-ports=sources.redhat.com@sourceware.org>
Received: (qmail 29863 invoked by alias); 6 Jan 2014 22:04:08 -0000
Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-ports.sourceware.org>
List-Subscribe: <mailto:libc-ports-subscribe@sourceware.org>
List-Post: <mailto:libc-ports@sourceware.org>
List-Help: <mailto:libc-ports-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: libc-ports-owner@sourceware.org
Received: (qmail 29852 invoked by uid 89); 6 Jan 2014 22:04:08 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-vb0-f50.google.com
Received: from mail-vb0-f50.google.com (HELO mail-vb0-f50.google.com) (209.85.212.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 06 Jan 2014 22:04:06 +0000
Received: by mail-vb0-f50.google.com with SMTP id w18so9235661vbj.23        for <libc-ports@sourceware.org>; Mon, 06 Jan 2014 14:04:04 -0800 (PST)
MIME-Version: 1.0
X-Received: by 10.52.164.203 with SMTP id ys11mr4169905vdb.37.1389045843960; Mon, 06 Jan 2014 14:04:03 -0800 (PST)
Received: by 10.58.178.207 with HTTP; Mon, 6 Jan 2014 14:04:03 -0800 (PST)
In-Reply-To: <CABXK9nd0E6gs1Ho4+0CeSsGic5KxyfB9z3JVDANtw4DC4kdHag@mail.gmail.com>
References: <CABXK9nd0E6gs1Ho4+0CeSsGic5KxyfB9z3JVDANtw4DC4kdHag@mail.gmail.com>
Date: Mon, 06 Jan 2014 22:04:00 -0000
Message-ID: <CA+=Sn1nsgyhkOWv=+JoX3ZKn6ENZ2Cg0VLmxF14u-q9iGLvh2Q@mail.gmail.com>
Subject: Re: [PATCH, COMMITTED] BZ #15128 [AArch64] Save and restore q0-q7 on entry to dynamic linker.
From: Andrew Pinski <pinskia@gmail.com>
To: Marcus Shawcroft <marcus.shawcroft@linaro.org>
Cc: libc-ports <libc-ports@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2014-01/txt/msg00017.txt.bz2

On Wed, Dec 18, 2013 at 4:05 AM, Marcus Shawcroft
<marcus.shawcroft@linaro.org> wrote:
> This patch ensures that all argument passing registers are saved and
> restored on entry to the dynamic linker and resolves BZ #15128.
>
> Regression tested.  Committed to trunk.  Back port to 2.18 branch will follow.


There is a bug in this patch:
- stp x8, x9, [sp, #-80]!
+ stp x8, x9, [sp, #-(80+8*16)]!
  cfi_adjust_cfa_offset (80)


You forgot to update the cfi_adjust_cfa_offset to be 80+8*16.

Thanks,
Andrew Pinski

>
> Cheers
> /Marcus