From: "Ryan S. Arnold" <ryan.arnold@gmail.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: libc-alpha@sourceware.org, libc-ports@sourceware.org
Subject: Re: Remove __ASSUME_VFORK_SYSCALL (and some __NR_vfork conditionals)
Date: Wed, 01 Aug 2012 20:34:00 -0000 [thread overview]
Message-ID: <CAAKybw-7GAnbvxG+AfXgVKOhF+85G8Ghmd6f=G3CjjGxfbzQwQ@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1207252217040.23471@digraph.polyomino.org.uk>
On Wed, Jul 25, 2012 at 5:19 PM, Joseph S. Myers
<joseph@codesourcery.com> wrote:
> The __ASSUME_VFORK_SYSCALL macro is only used in architecture-specific
> .S sources, and now defined for all kernel versions on the three
> architectures with such sources using the macro (i386, powerpc, m68k).
> Thus it is redundant and can be removed. Furthermore, the __NR_vfork
> conditionals in those same sources are also redundant relics of old
> kernel support, since the __NR_vfork macro is defined for those
> architectures as of 2.6.19.1 (the earliest kernel headers version now
> supported).
>
> Thus I propose this patch to remove __ASSUME_VFORK_SYSCALL, and the
> redundant __NR_vfork conditionals in the files being changed. Tested
> x86. Could powerpc and m68k maintainers review / test the changes to
> their ports?
>
> (The present sequence of patches aims at removing the __ASSUME_* form
> of support for kernels before, in the end, 2.6.16, with __NR_*
> conditionals being removed only incidentally to the __ASSUME_*
> conditionals removal. But I might look for unnecessary __NR_*
> conditionals later and would certainly encourage port maintainers to
> clean them up in their ports - I've done so myself for ARM and MIPS.
> If the __NR_* macro is present by 2.6.19.1, for all architectures
> using a given file (directly or indirectly), then the conditionals on
> that macro being defined are not needed in that file.)
>
> 2012-07-25 Joseph Myers <joseph@codesourcery.com>
>
> * sysdeps/unix/sysv/linux/kernel-features.h
> (__ASSUME_VFORK_SYSCALL): Remove all definitions.
> * sysdeps/unix/sysv/linux/i386/vfork.S (__vfork) [__NR_vfork]:
> Make code unconditional.
> (__vfork) [__ASSUME_VFORK_SYSCALL]: Likewise.
> (__vfork) [!__ASSUME_VFORK_SYSCALL]: Remove conditional code.
> * sysdeps/unix/sysv/linux/powerpc/powerpc32/vfork.S (__vfork)
> [__NR_vfork]: Make code unconditional.
> (__vfork) [__ASSUME_VFORK_SYSCALL]: Likewise.
> (__vfork) [!__ASSUME_VFORK_SYSCALL]: Remove conditional code.
> * sysdeps/unix/sysv/linux/powerpc/powerpc64/vfork.S (__vfork)
> [__NR_vfork]: Make code unconditional.
> (__vfork) [__ASSUME_VFORK_SYSCALL]: Likewise.
> (__vfork) [!__ASSUME_VFORK_SYSCALL]: Remove conditional code.
>
> ports/ChangeLog.arm:
> 2012-07-25 Joseph Myers <joseph@codesourcery.com>
>
> * sysdeps/unix/sysv/linux/arm/kernel-features.h
> (__ASSUME_VFORK_SYSCALL: Remove.
>
> ports/ChangeLog.m68k:
> 2012-07-25 Joseph Myers <joseph@codesourcery.com>
>
> * sysdeps/unix/sysv/linux/m68k/kernel-features.h
> (__ASSUME_VFORK_SYSCALL): Remove.
> * sysdeps/unix/sysv/linux/m68k/vfork.S (__vfork) [__NR_vfork]:
> Make code unconditional.
> (__vfork) [__ASSUME_VFORK_SYSCALL]: Likewise.
> (__vfork) [!__ASSUME_VFORK_SYSCALL]: Remove conditional code.
Tested on powerpc32 and powerpc64 and no new regressions were identified.
Ryan S. Arnold
prev parent reply other threads:[~2012-08-01 20:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 22:19 Joseph S. Myers
2012-07-25 22:45 ` Roland McGrath
2012-07-26 7:09 ` Andreas Schwab
2012-08-01 20:34 ` Ryan S. Arnold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAKybw-7GAnbvxG+AfXgVKOhF+85G8Ghmd6f=G3CjjGxfbzQwQ@mail.gmail.com' \
--to=ryan.arnold@gmail.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-ports@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).