From: Marcus Shawcroft <marcus.shawcroft@linaro.org>
To: libc-ports <libc-ports@sourceware.org>
Subject: [PATCH] AArch64 compile dbl-64/e_sqrt.c with -ffp-contract=off
Date: Tue, 17 Dec 2013 13:17:00 -0000 [thread overview]
Message-ID: <CABXK9nccf63UL5G3SJCc+C6oQCWu_iDhG2h8jNa_gM-s5ENCqA@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 365 bytes --]
This patch fixes the numerical errors in aarch64 sqrt() due to the
compilers use of fnmsub (negated fused multiply-subtract).
Previous thread:
https://sourceware.org/ml/libc-alpha/2013-12/msg00473.html
I'll leave this on the list for 24 hours before committing to give
folks the opportunity to comment on the (in)appropriateness of my
solution...
Cheers
/Marcus
[-- Attachment #2: glibc-e_sqrt-flags.txt --]
[-- Type: text/plain, Size: 769 bytes --]
diff --git a/ports/ChangeLog.aarch64 b/ports/ChangeLog.aarch64
index 09645c3..e65e87a 100644
--- a/ports/ChangeLog.aarch64
+++ b/ports/ChangeLog.aarch64
@@ -1,3 +1,8 @@
+2013-12-17 Marcus Shawcroft <marcus.shawcroft@linaro.org>
+
+ * sysdeps/aarch64/Makefile (CFLAGS-e_sqrt.c): Add
+ $(config-cflags-nofma).
+
2013-12-17 Marcus Shawcroft <marcus.shawcroft@linaro.org>
* sysdeps/aarch64/libm-test-ulps: Regenerated.
diff --git a/ports/sysdeps/aarch64/Makefile b/ports/sysdeps/aarch64/Makefile
index 5af7a16..43341c1 100644
--- a/ports/sysdeps/aarch64/Makefile
+++ b/ports/sysdeps/aarch64/Makefile
@@ -14,3 +14,7 @@ endif
ifeq ($(subdir),csu)
gen-as-const-headers += tlsdesc.sym
endif
+
+ifeq ($(subdir),math)
+CFLAGS-e_sqrt.c = $(config-cflags-nofma)
+endif
next reply other threads:[~2013-12-17 13:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 13:17 Marcus Shawcroft [this message]
2013-12-17 14:20 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABXK9nccf63UL5G3SJCc+C6oQCWu_iDhG2h8jNa_gM-s5ENCqA@mail.gmail.com \
--to=marcus.shawcroft@linaro.org \
--cc=libc-ports@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).