From: "Carlos O'Donell" <carlos@systemhalted.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Roland McGrath <roland@hack.frob.com>, libc-ports@sourceware.org
Subject: Re: [PATCH] ia64: move from main tree
Date: Mon, 16 Apr 2012 18:06:00 -0000 [thread overview]
Message-ID: <CADZpyixMVc3eZY+s-9BJBoemNbWaTRv19cJ1R0Bw6Mfgpibqow@mail.gmail.com> (raw)
In-Reply-To: <201204161404.21458.vapier@gentoo.org>
On Mon, Apr 16, 2012 at 2:04 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Monday 16 April 2012 12:53:53 Roland McGrath wrote:
>> I'm not going to review any of the ia64 content. I'll just say that I
>> think this should be done with multiple commits, each with proper ChangeLog
>> bits. First, just resurrect old files verbatim. Then each of your bullet
>> items is a separate commit with normal detailed entries in ChangeLog.ia64.
>
> i couldn't tell if people would be ok merging code that is known to be broken.
> i could break up this commit into multiple ones (original code + mangling
> afterwards), but really none of it would be usable until all of it was merged.
You want others to help you! :-)
What matters is that you make it easy for others to review your ia64 fix.
If you submit restoration + fix then I can't easily spot check the
changes and recommend fixes.
Cheers,
Carlos.
next prev parent reply other threads:[~2012-04-16 18:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 2:50 Mike Frysinger
2012-04-16 3:09 ` Mike Frysinger
2012-04-16 16:54 ` Roland McGrath
2012-04-16 18:04 ` Mike Frysinger
2012-04-16 18:06 ` Carlos O'Donell [this message]
2012-04-16 18:11 ` Roland McGrath
2012-04-16 18:13 ` Carlos O'Donell
2012-04-16 18:27 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADZpyixMVc3eZY+s-9BJBoemNbWaTRv19cJ1R0Bw6Mfgpibqow@mail.gmail.com \
--to=carlos@systemhalted.org \
--cc=libc-ports@sourceware.org \
--cc=roland@hack.frob.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).