From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10936 invoked by alias); 6 May 2012 21:36:27 -0000 Received: (qmail 10838 invoked by uid 22791); 6 May 2012 21:36:25 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-pb0-f41.google.com (HELO mail-pb0-f41.google.com) (209.85.160.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 06 May 2012 21:36:12 +0000 Received: by pbbrp2 with SMTP id rp2so6225322pbb.0 for ; Sun, 06 May 2012 14:36:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.202.8 with SMTP id ke8mr4724280pbc.94.1336340171896; Sun, 06 May 2012 14:36:11 -0700 (PDT) Received: by 10.68.48.8 with HTTP; Sun, 6 May 2012 14:36:11 -0700 (PDT) In-Reply-To: References: <4F886201.3040200@redhat.com> <4F886277.6000006@redhat.com> <20120413173512.5D52B2C074@topped-with-meat.com> <4F9515D5.60804@redhat.com> <4F99B990.7020300@mentor.com> <20120426220656.0CC302C0D3@topped-with-meat.com> Date: Sun, 06 May 2012 21:36:00 -0000 Message-ID: Subject: Re: [WIP] glibc: Use /lib/ld-linux-armhf.so.3 for ARM's -mfloat-abi=hard ABI. From: "Carlos O'Donell" To: "Joseph S. Myers" Cc: Roland McGrath , "Carlos O'Donell" , Andrew Haley , libc-ports@sourceware.org, steve.mcintyre@linaro.org, michael.hope@linaro.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00022.txt.bz2 On Sun, May 6, 2012 at 8:13 AM, Joseph S. Myers w= rote: > On Sat, 5 May 2012, Carlos O'Donell wrote: > >> * Define HAVE_ARM_PCS_VFP in config.h.in > > Is there a way we can avoid architecture-specific defines needing to go in > config.h.in - have architecture-specific files instead that it includes in > some way? =A0Does it work for configure.in fragments to use > AC_CONFIG_HEADERS naming their own config.h.in fragments - will each > fragment then get the right substitutions made on it? =A0(A mechanism wou= ld > also be needed for all the fragments to get included automatically - > probably the main config.h should include all the others.) I don't think it possible to achieve any of your suggestions without additional work on the glibc build infrastructure. I completely agree with you, and such a solution would move the PPC config.h.in defines into their own fragment, but such work is outside the scope of the current ARM hard-float dynamic linker change. > (The same issue applies with AC_SUBST as with AC_DEFINE - there shouldn't > need to be a load of architecture-specific AC_SUBSTs in configure.in and > config.make.in. =A0But let's see if it can be solved for config.h.in firs= t.) The cleanup of the master config.h.in can be done as a separate step and should be done with review from other glibc developers and with more time for review. We should not block the current inclusion of the ARM glibc changes which the community is waiting to use. >> To tell you the truth at this late hour I can't remember why we're >> doing this in preconfigure, why can't this all be in >> sysdeps/arm/configure.in where I can use AC_DEFINE? > > preconfigure is only relevant for choosing sysdeps directories. =A0For > defining something, sysdeps/arm/configure.in should work. I'll use sysdeps/arm/configure.in and thus avoid the confdefs.h hack in preconfigure. I'll post a patch shortly. Cheers, Carlos.