From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22624 invoked by alias); 9 Aug 2012 22:56:38 -0000 Received: (qmail 22614 invoked by uid 22791); 9 Aug 2012 22:56:37 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-vb0-f41.google.com (HELO mail-vb0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 09 Aug 2012 22:56:23 +0000 Received: by vbkv13 with SMTP id v13so1094607vbk.0 for ; Thu, 09 Aug 2012 15:56:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.157.65 with SMTP id a1mr769508vcx.39.1344552982810; Thu, 09 Aug 2012 15:56:22 -0700 (PDT) Received: by 10.58.236.198 with HTTP; Thu, 9 Aug 2012 15:56:22 -0700 (PDT) In-Reply-To: <20120808215850.048902C0ED@topped-with-meat.com> References: <20120808215850.048902C0ED@topped-with-meat.com> Date: Thu, 09 Aug 2012 22:56:00 -0000 Message-ID: Subject: Re: [COMMITTED PATCH] add missing const in arm_gnu_pltexit signature From: "Carlos O'Donell" To: Roland McGrath Cc: libc-ports@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00086.txt.bz2 On Wed, Aug 8, 2012 at 5:58 PM, Roland McGrath wrote: > This fixes a 'discarded const' warning compiling dl-runtime.c, because > the signature of the function pointer lacked the const that other machines > have. > > Committed as obvious. > > > Thanks, > Roland > > > ports/ChangeLog.arm > * sysdeps/arm/ldsodefs.h (ARCH_PLTEXIT_MEMBERS): Use const on > `struct La_arm_regs *' parameter. > > diff --git a/ports/sysdeps/arm/ldsodefs.h b/ports/sysdeps/arm/ldsodefs.h > index aa323d3..73375b6 100644 > --- a/ports/sysdeps/arm/ldsodefs.h > +++ b/ports/sysdeps/arm/ldsodefs.h > @@ -1,5 +1,5 @@ > /* Run-time dynamic linker data structures for loaded ELF shared objects. > - Copyright (C) 2005 Free Software Foundation, Inc. > + Copyright (C) 2005-2012 Free Software Foundation, Inc. > This file is part of the GNU C Library. > > The GNU C Library is free software; you can redistribute it and/or > @@ -32,7 +32,7 @@ struct La_arm_retval; > > #define ARCH_PLTEXIT_MEMBERS \ > Elf32_Addr (*arm_gnu_pltexit) (Elf32_Sym *, unsigned int, uintptr_t *, \ > - uintptr_t *, struct La_arm_regs *, \ > + uintptr_t *, const struct La_arm_regs *, \ > struct La_arm_retval *, const char *) > > #include_next I did a quick scan of all the other targets and noticed something I thought was odd... Why do sh, sparc, mips, m68k, ia64, alpha use `const struct La_sh_regs *' for ARCH_PLTENTER_MEMBERS? Shouldn't that set of register be modifiable by the called audit function? Cheers, Carlos.