Re: [ARM] getcontext routines v2

["Carlos O'Donell" <carlos@systemhalted.org>]

On Mon, Feb 27, 2012 at 5:03 PM, Michael Hope <michael.hope@linaro.org> wrote:
>> I looked over things briefly and the formatting and license looks OK.
>> Do you and Dave have FSF copyright assignments in place?
>
> Yes.  Linaro has an assignment agreement for GCC, GDB, binutils, and GLIBC
> under case #664398.

Excellent. Thanks.

>> (1) Is setcontext correctly implemented?
> It's correct to the specification and matches the MIPS and Tile ports.  From
> IEEE 1003.1:2004:

I've gone and re-read the standard, and I agree with you.

Personally I think there is a QoI issue here, but you meet the
standard which is the right thing to do.

>> I'd be interested in seeing if you pass all of the glibc tests.
> There are no regressions between EGLIBC trunk and trunk + this patch.
>  stdlib/bug-getcontext now passes.  The (small) GNU pth testsuite passes.

Perfect.

>> (2) Please also post a GNU ChangeLog with your patches.
> Done.

Thanks.

> -- Michael
>
> diff --git a/ChangeLog.arm b/ChangeLog.arm
> index 9eef7e7..7ecb11b 100644
> --- a/ChangeLog.arm
> +++ b/ChangeLog.arm
> @@ -1,3 +1,13 @@
> +2012-02-27  Michael Hope  <michael.hope@linaro.org>
> +
> +       * sysdeps/unix/sysv/linux/arm/eabi/getcontext.S: New file.
> +       * sysdeps/unix/sysv/linux/arm/eabi/makecontext.c: New file.
> +       * sysdeps/unix/sysv/linux/arm/eabi/setcontext.S: New file.
> +       * sysdeps/unix/sysv/linux/arm/eabi/swapcontext.S: New file.
> +       * sysdeps/unix/sysv/linux/arm/ucontext_i.sym: New file.
> +       * sysdeps/unix/sysv/linux/arm/Makefile (gen-as-const-headers): Add
> +       ucontext_i.sym.
> +
>  2012-02-17  Aurelien Jarno  <aurelien@aurel32.net>
>
>        * sysdeps/arm/libm-test-ulps: Adjust ULPs for jn tests.
>
> diff --git a/sysdeps/unix/sysv/linux/arm/Makefile
> b/sysdeps/unix/sysv/linux/arm/Makefile
> index d91b968..a981736 100644
> --- a/sysdeps/unix/sysv/linux/arm/Makefile
> +++ b/sysdeps/unix/sysv/linux/arm/Makefile
> @@ -20,3 +20,7 @@ endif
>  ifeq ($(subdir),resource)
>  sysdep_routines += oldgetrlimit64
>  endif
> +
> +ifeq ($(subdir),stdlib)
> +gen-as-const-headers += ucontext_i.sym
> +endif
> diff --git a/sysdeps/unix/sysv/linux/arm/eabi/getcontext.S
> b/sysdeps/unix/sysv/linux/arm/eabi/getcontext.S
> new file mode 100644
> index 0000000..11a49e3
> --- /dev/null
> +++ b/sysdeps/unix/sysv/linux/arm/eabi/getcontext.S
> @@ -0,0 +1,114 @@
> +/* Copyright (C) 2012 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.
> +
> +   The GNU C Library is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU Lesser General Public
> +   License as published by the Free Software Foundation; either
> +   version 2.1 of the License, or (at your option) any later version.
> +
> +   The GNU C Library is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +   Lesser General Public License for more details.
> +
> +   You should have received a copy of the GNU Lesser General Public
> +   License along with the GNU C Library; if not, write to the Free
> +   Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
> +   02111-1307 USA.  */
> +

This should be:
~~~
   License along with the GNU C Library; if not, see
   <http://www.gnu.org/licenses/>.  */
~~~

We don't use the address form of the license.

Please repost the patch with the license change and I'll check it in.

Cheers,
Carlos.