From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9263 invoked by alias); 27 Feb 2012 23:06:01 -0000 Received: (qmail 9254 invoked by uid 22791); 27 Feb 2012 23:05:59 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-gx0-f175.google.com (HELO mail-gx0-f175.google.com) (209.85.161.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 27 Feb 2012 23:05:46 +0000 Received: by ggeq1 with SMTP id q1so2388566gge.20 for ; Mon, 27 Feb 2012 15:05:45 -0800 (PST) Received-SPF: pass (google.com: domain of patofiero@gmail.com designates 10.236.76.133 as permitted sender) client-ip=10.236.76.133; Authentication-Results: mr.google.com; spf=pass (google.com: domain of patofiero@gmail.com designates 10.236.76.133 as permitted sender) smtp.mail=patofiero@gmail.com; dkim=pass header.i=patofiero@gmail.com Received: from mr.google.com ([10.236.76.133]) by 10.236.76.133 with SMTP id b5mr25027672yhe.0.1330383945550 (num_hops = 1); Mon, 27 Feb 2012 15:05:45 -0800 (PST) MIME-Version: 1.0 Received: by 10.236.76.133 with SMTP id b5mr18771015yhe.0.1330383945491; Mon, 27 Feb 2012 15:05:45 -0800 (PST) Received: by 10.146.84.1 with HTTP; Mon, 27 Feb 2012 15:05:45 -0800 (PST) In-Reply-To: <4F4BFDA6.1070602@linaro.org> References: <4F46E90C.3010305@linaro.org> <4F4BFDA6.1070602@linaro.org> Date: Mon, 27 Feb 2012 23:06:00 -0000 Message-ID: Subject: Re: [ARM] getcontext routines v2 From: "Carlos O'Donell" To: Michael Hope Cc: libc-ports@sources.redhat.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00078.txt.bz2 On Mon, Feb 27, 2012 at 5:03 PM, Michael Hope wro= te: >> I looked over things briefly and the formatting and license looks OK. >> Do you and Dave have FSF copyright assignments in place? > > Yes. =A0Linaro has an assignment agreement for GCC, GDB, binutils, and GL= IBC > under case #664398. Excellent. Thanks. >> (1) Is setcontext correctly implemented? > It's correct to the specification and matches the MIPS and Tile ports. = =A0From > IEEE 1003.1:2004: I've gone and re-read the standard, and I agree with you. Personally I think there is a QoI issue here, but you meet the standard which is the right thing to do. >> I'd be interested in seeing if you pass all of the glibc tests. > There are no regressions between EGLIBC trunk and trunk + this patch. > =A0stdlib/bug-getcontext now passes. =A0The (small) GNU pth testsuite pas= ses. Perfect. >> (2) Please also post a GNU ChangeLog with your patches. > Done. Thanks. > -- Michael > > diff --git a/ChangeLog.arm b/ChangeLog.arm > index 9eef7e7..7ecb11b 100644 > --- a/ChangeLog.arm > +++ b/ChangeLog.arm > @@ -1,3 +1,13 @@ > +2012-02-27 =A0Michael Hope =A0 > + > + =A0 =A0 =A0 * sysdeps/unix/sysv/linux/arm/eabi/getcontext.S: New file. > + =A0 =A0 =A0 * sysdeps/unix/sysv/linux/arm/eabi/makecontext.c: New file. > + =A0 =A0 =A0 * sysdeps/unix/sysv/linux/arm/eabi/setcontext.S: New file. > + =A0 =A0 =A0 * sysdeps/unix/sysv/linux/arm/eabi/swapcontext.S: New file. > + =A0 =A0 =A0 * sysdeps/unix/sysv/linux/arm/ucontext_i.sym: New file. > + =A0 =A0 =A0 * sysdeps/unix/sysv/linux/arm/Makefile (gen-as-const-header= s): Add > + =A0 =A0 =A0 ucontext_i.sym. > + > =A02012-02-17 =A0Aurelien Jarno =A0 > > =A0 =A0 =A0 =A0* sysdeps/arm/libm-test-ulps: Adjust ULPs for jn tests. > > diff --git a/sysdeps/unix/sysv/linux/arm/Makefile > b/sysdeps/unix/sysv/linux/arm/Makefile > index d91b968..a981736 100644 > --- a/sysdeps/unix/sysv/linux/arm/Makefile > +++ b/sysdeps/unix/sysv/linux/arm/Makefile > @@ -20,3 +20,7 @@ endif > =A0ifeq ($(subdir),resource) > =A0sysdep_routines +=3D oldgetrlimit64 > =A0endif > + > +ifeq ($(subdir),stdlib) > +gen-as-const-headers +=3D ucontext_i.sym > +endif > diff --git a/sysdeps/unix/sysv/linux/arm/eabi/getcontext.S > b/sysdeps/unix/sysv/linux/arm/eabi/getcontext.S > new file mode 100644 > index 0000000..11a49e3 > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/arm/eabi/getcontext.S > @@ -0,0 +1,114 @@ > +/* Copyright (C) 2012 Free Software Foundation, Inc. > + =A0 This file is part of the GNU C Library. > + > + =A0 The GNU C Library is free software; you can redistribute it and/or > + =A0 modify it under the terms of the GNU Lesser General Public > + =A0 License as published by the Free Software Foundation; either > + =A0 version 2.1 of the License, or (at your option) any later version. > + > + =A0 The GNU C Library is distributed in the hope that it will be useful, > + =A0 but WITHOUT ANY WARRANTY; without even the implied warranty of > + =A0 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. =A0See the GNU > + =A0 Lesser General Public License for more details. > + > + =A0 You should have received a copy of the GNU Lesser General Public > + =A0 License along with the GNU C Library; if not, write to the Free > + =A0 Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA > + =A0 02111-1307 USA. =A0*/ > + This should be: ~~~ License along with the GNU C Library; if not, see . */ ~~~ We don't use the address form of the license. Please repost the patch with the license change and I'll check it in. Cheers, Carlos.