public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
* Fix arm warning
@ 2012-04-16 10:17 Andreas Jaeger
  2012-04-16 23:25 ` Carlos O'Donell
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Jaeger @ 2012-04-16 10:17 UTC (permalink / raw)
  To: libc-ports

Building for ARM I got lots of these warnings:
../glibc-ports-2.15/sysdeps/unix/sysv/linux/arm/ldsodefs.h:41:0: warning: 
"MORE_ELF_HEADER_DATA" redefined [enabled by default]
../sysdeps/unix/sysv/linux/ldsodefs.h:64:0: note: this is the location of 
the previous definition

This is still in git head. Let's undef it like we undef the other 
variables.

Ok to commit?
Andreas

2012-04-16  Andreas Jaeger  <aj@suse.de>

	* sysdeps/unix/sysv/linux/arm/ldsodefs.h: Undefine
	MORE_ELF_HEADER_DATA to avoid warnings about redefinition.

diff --git a/sysdeps/unix/sysv/linux/arm/ldsodefs.h 
b/sysdeps/unix/sysv/linux/arm/ldsodefs.h
index 839dc18..6966f8a 100644
--- a/sysdeps/unix/sysv/linux/arm/ldsodefs.h
+++ b/sysdeps/unix/sysv/linux/arm/ldsodefs.h
@@ -1,5 +1,5 @@
 /* Run-time dynamic linker data structures for loaded ELF shared objects.
-   Copyright (C) 2010 Free Software Foundation, Inc.
+   Copyright (C) 2010, 2012 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -23,6 +23,7 @@
 
 #undef VALID_ELF_HEADER
 #undef VALID_ELF_OSABI
+#undef MORE_ELF_HEADER_DATA
 
 #ifdef __ARM_EABI__
 #define EXTRA_OSABI ELFOSABI_ARM_AEABI

-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Fix arm warning
  2012-04-16 10:17 Fix arm warning Andreas Jaeger
@ 2012-04-16 23:25 ` Carlos O'Donell
  0 siblings, 0 replies; 2+ messages in thread
From: Carlos O'Donell @ 2012-04-16 23:25 UTC (permalink / raw)
  To: Andreas Jaeger; +Cc: libc-ports

On Mon, Apr 16, 2012 at 6:17 AM, Andreas Jaeger <aj@suse.com> wrote:
> Building for ARM I got lots of these warnings:
> ../glibc-ports-2.15/sysdeps/unix/sysv/linux/arm/ldsodefs.h:41:0: warning:
> "MORE_ELF_HEADER_DATA" redefined [enabled by default]
> ../sysdeps/unix/sysv/linux/ldsodefs.h:64:0: note: this is the location of
> the previous definition
>
> This is still in git head. Let's undef it like we undef the other
> variables.
>
> Ok to commit?
> Andreas
>
> 2012-04-16  Andreas Jaeger  <aj@suse.de>
>
>        * sysdeps/unix/sysv/linux/arm/ldsodefs.h: Undefine
>        MORE_ELF_HEADER_DATA to avoid warnings about redefinition.

Please commit.

IMO this is a trivial change.

Cheers,
Carlos.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-04-16 23:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-16 10:17 Fix arm warning Andreas Jaeger
2012-04-16 23:25 ` Carlos O'Donell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).