From: "Carlos O'Donell" <carlos@systemhalted.org>
To: Andrew Pinski <pinskia@gmail.com>
Cc: Steve Ellcey <sellcey@mips.com>,
"Joseph S. Myers" <joseph@codesourcery.com>,
"Carlos O'Donell" <carlos@redhat.com>,
"libc-ports@sourceware.org" <libc-ports@sourceware.org>
Subject: Re: [patch, mips] Improved memset for MIPS
Date: Fri, 13 Dec 2013 00:01:00 -0000 [thread overview]
Message-ID: <CAE2sS1iqz-GVB8hZVbZL7D4hr6Xs09ofPtaU2WQ6wzeBAjcf8w@mail.gmail.com> (raw)
In-Reply-To: <CA+=Sn1=87nKm1ShivDn5dJ29dNg5zYgQ58uSfWb18+mXh3-spA@mail.gmail.com>
On Thu, Dec 12, 2013 at 5:19 PM, Andrew Pinski <pinskia@gmail.com> wrote:
> On Fri, Sep 20, 2013 at 10:32 AM, Steve Ellcey <sellcey@mips.com> wrote:
>> On Fri, 2013-09-20 at 16:43 +0000, Joseph S. Myers wrote:
>>> On Wed, 18 Sep 2013, Steve Ellcey wrote:
>>>
>>> > 2013-09-18 Steve Ellcey <sellcey@mips.com>
>>> >
>>> > * sysdeps/mips/memset.S: Change prefetching and add loop unrolling.
>>> > * sysdeps/mips/mips64/memset.S: Remove.
>>>
>>> OK, though I believe "proAptive" in a comment should be "proAptiv".
>>
>> You are right. I fixed that and checked in the patch.
>
>
> I noticed this patch causes some performance regressions on Octeon due
> to having 128 byte cache lines.
> Changing PREFETCH_CHUNK/PREFETCH_FOR_STORE to assume 128 byte cache
> line gives us the performance back and improves over the original code
> at least 15%.
> That is:
> # define PREFETCH_CHUNK 128
> # define PREFETCH_FOR_STORE(chunk, reg) \
> pref PREFETCH_STORE_HINT, (chunk)*128(reg);
Submit a patch for that?
We have microbenchmarks now, but the next hardest
part is going to be archiving data by device so that
the community can help track performance and point
out regressions like this.
Cheers,
Carlos.
next prev parent reply other threads:[~2013-12-13 0:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 17:06 Steve Ellcey
2013-09-06 0:40 ` Mike Frysinger
2013-09-06 15:42 ` Steve Ellcey
2013-09-06 4:18 ` Carlos O'Donell
2013-09-06 16:03 ` Steve Ellcey
2013-09-06 17:12 ` Carlos O'Donell
2013-09-06 23:33 ` Steve Ellcey
2013-09-07 2:38 ` Carlos O'Donell
2013-09-10 20:31 ` Steve Ellcey
2013-09-10 21:01 ` Carlos O'Donell
2013-09-10 21:14 ` Steve Ellcey
2013-09-10 22:35 ` Carlos O'Donell
2013-09-10 22:38 ` Carlos O'Donell
2013-09-07 5:46 ` Andreas Schwab
2013-09-06 14:31 ` Joseph S. Myers
2013-09-06 15:58 ` Steve Ellcey
2013-09-06 16:09 ` Joseph S. Myers
2013-09-06 16:50 ` Steve Ellcey
2013-09-06 16:59 ` Joseph S. Myers
2013-09-06 17:43 ` Steve Ellcey
2013-09-06 18:57 ` Brooks Moses
2013-09-18 17:41 ` Steve Ellcey
2013-09-19 15:25 ` Carlos O'Donell
2013-09-19 17:02 ` Steve Ellcey
2013-09-20 16:43 ` Joseph S. Myers
2013-09-20 17:32 ` Steve Ellcey
2013-12-12 22:19 ` Andrew Pinski
2013-12-13 0:01 ` Carlos O'Donell [this message]
2013-12-13 0:14 ` Steve Ellcey
2013-12-13 0:22 ` Andrew Pinski
2013-12-13 4:40 ` Carlos O'Donell
2013-09-06 16:59 ` Steve Ellcey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE2sS1iqz-GVB8hZVbZL7D4hr6Xs09ofPtaU2WQ6wzeBAjcf8w@mail.gmail.com \
--to=carlos@systemhalted.org \
--cc=carlos@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=pinskia@gmail.com \
--cc=sellcey@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).