From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7545 invoked by alias); 13 Dec 2013 00:01:57 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 7535 invoked by uid 89); 13 Dec 2013 00:01:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: mail-bk0-f45.google.com Received: from mail-bk0-f45.google.com (HELO mail-bk0-f45.google.com) (209.85.214.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 13 Dec 2013 00:01:54 +0000 Received: by mail-bk0-f45.google.com with SMTP id mx13so1150134bkb.18 for ; Thu, 12 Dec 2013 16:01:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=sv7WSgc01V4HwcUhyFSWwCVqKsDVbvRUlyxw+2HnvGk=; b=TvJQHWMxFfzvw+N4AEQs7NrDqgQI8EEPq++cCXlNeBMbXrO+Ns6/2d5eztW2wlZNWs vB+qPs3YcdSruR/LZDf8M1Rh69/s4IQHOwMUlMvDcJ5V3XyZ/UHOUscapHPEG/OZWPTN Dypjic7TuexAS5KEDzkt9jY7pjo6bMxWEnrxK+cwNsVSXNzbehcrMRiyoCz9+poXLnxb 8I0yhYz6Q/2zHkwN+dQOMNrQN6m49IZ5eQyWjqOfmbxUvGLTaLkonXF2TLe7myVdbhP6 78tifD0fPG3hL/vEe99d7Jv5NVnF96pOUT9k/XFUsCD8WqhubkxTQ6YkbvwoOjJ7OJQ/ 2dXg== X-Gm-Message-State: ALoCoQnf5d9v5CBRt9iPWiksdh618RzljzHC3SrME/G85fudTKEegM/SfQQuwtPo9/uk51bUJHvA MIME-Version: 1.0 X-Received: by 10.204.234.202 with SMTP id kd10mr4961bkb.53.1386892911542; Thu, 12 Dec 2013 16:01:51 -0800 (PST) Received: by 10.204.103.7 with HTTP; Thu, 12 Dec 2013 16:01:51 -0800 (PST) In-Reply-To: References: <93a232b5-9d0b-4a27-bbb5-16e3ae7c4b89@BAMAIL02.ba.imgtec.org> <1378483039.5770.302.camel@ubuntu-sellcey> <1378486241.5770.327.camel@ubuntu-sellcey> <1379526035.5770.414.camel@ubuntu-sellcey> <1379698355.5770.466.camel@ubuntu-sellcey> Date: Fri, 13 Dec 2013 00:01:00 -0000 Message-ID: Subject: Re: [patch, mips] Improved memset for MIPS From: "Carlos O'Donell" To: Andrew Pinski Cc: Steve Ellcey , "Joseph S. Myers" , "Carlos O'Donell" , "libc-ports@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00013.txt.bz2 On Thu, Dec 12, 2013 at 5:19 PM, Andrew Pinski wrote: > On Fri, Sep 20, 2013 at 10:32 AM, Steve Ellcey wrote: >> On Fri, 2013-09-20 at 16:43 +0000, Joseph S. Myers wrote: >>> On Wed, 18 Sep 2013, Steve Ellcey wrote: >>> >>> > 2013-09-18 Steve Ellcey >>> > >>> > * sysdeps/mips/memset.S: Change prefetching and add loop unrolling. >>> > * sysdeps/mips/mips64/memset.S: Remove. >>> >>> OK, though I believe "proAptive" in a comment should be "proAptiv". >> >> You are right. I fixed that and checked in the patch. > > > I noticed this patch causes some performance regressions on Octeon due > to having 128 byte cache lines. > Changing PREFETCH_CHUNK/PREFETCH_FOR_STORE to assume 128 byte cache > line gives us the performance back and improves over the original code > at least 15%. > That is: > # define PREFETCH_CHUNK 128 > # define PREFETCH_FOR_STORE(chunk, reg) \ > pref PREFETCH_STORE_HINT, (chunk)*128(reg); Submit a patch for that? We have microbenchmarks now, but the next hardest part is going to be archiving data by device so that the community can help track performance and point out regressions like this. Cheers, Carlos.